[elements.forms] New partial for form "resetting"? #156

Closed
csshugs opened this Issue Aug 30, 2016 · 5 comments

Projects

None yet

3 participants

@csshugs
Member
csshugs commented Aug 30, 2016

I'm porting this issue over from the deprecated CONTRIBUTING repo. Thanks @corbpaul for addressing this.

The question is whether we should provide a kind of reset file for forms like so.

Would this still be generic enough, or is this too opinionated for inuitcss?

@csshugs csshugs added the enhancement label Aug 30, 2016
@csshugs csshugs referenced this issue in inuitcss/CONTRIBUTING Aug 30, 2016
Closed

Add base/forms module #21

@anselmh
Member
anselmh commented Aug 30, 2016

IMO it’s not too opinionated and I’d love to see this in inuitcss.

@csshugs
Member
csshugs commented Aug 30, 2016

Anyone got other best practices to be add to this?

@nenadjelovac
Member

@csshugs it seems to me that what you added should actually go in _generic.reset.scss, instead of separate file in elements layer. I say that because all there is are bunch of properties that just reset values.

@csshugs
Member
csshugs commented Oct 12, 2016

@nenadjelovac Yeah, you're right. I modified that.

@csshugs
Member
csshugs commented Oct 18, 2016

#193 is merged

@csshugs csshugs closed this Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment