Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Render date ranges #59
Hey @inukshuk , thanks for working on this! I had been trying, but I see looking at your code I wasn't even close to figuring out how to interact with the CSL nodes to do what was needed.
I think it's fine if it doesn't work for some edge cases -- prior to this, it didn't work at all, so.
However, I'm afraid it's not working for me for basic use cases.
I am trying with a csl-data-json object that has
Running this through the
Trying other input with months and dates, it also is not working -- only including the end of range, and sometimes not including month/date from end of range as expected either.
@jrochkind yes, this is not fully functional yet; for starters, check out the TODO at line 41 above -- the
Ah, right on, thanks. Appreciate seeing the code.
I'll see if I can find time to take it further -- the fact that code needs to be split between two gems, which need to have their changes and releases synchronized... makes things harder. I wonder if it makes sense to temporarily or as fallback put the func in this gem?
I'll see if I can find time -- but I might end up just passing in a date with a