Preventing @string objects being passed to the renderer. #170

Merged
merged 2 commits into from Oct 3, 2016

Projects

None yet

2 participants

@tom-jin
Contributor
tom-jin commented Oct 3, 2016

When negative queries are used objects that are not bibtex entries get passed the the 'entries' function to methods that render bibliography entries. These @string and @preface objects cause errors when functions expect to find certain fields in them.

I have written a test to reproduce this case and one way of ensuring the entries function only returns an array of entries.

tom-jin added some commits Oct 3, 2016
@tom-jin tom-jin Add failing test for bibtex string replacement with negative queries. 4e2b252
@tom-jin tom-jin Fix entries returing non-BibTeX::Entry objects.
6bf07ef
@inukshuk inukshuk merged commit 4b8c0f2 into inukshuk:master Oct 3, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.818%
Details
@inukshuk
Owner
inukshuk commented Oct 3, 2016

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment