Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in remove() using angular nicescroll with modal popup #683

Open
inuyaksa opened this issue Jul 19, 2017 · 14 comments
Open

Error in remove() using angular nicescroll with modal popup #683

inuyaksa opened this issue Jul 19, 2017 · 14 comments

Comments

@inuyaksa
Copy link
Owner

inuyaksa commented Jul 19, 2017

started from #677 (comment)

inuyaksa added a commit that referenced this issue Jul 19, 2017
Fixes
- Error in remove() using angular nicescroll with modal popup #683
@pandu5164
Copy link

pandu5164 commented Jul 20, 2017

I'm still getting issue in my application. The demo given by you works fine and the same way i too implemented but still i'm able to reproduce the error.
Actually as some events are not getting disposed i'm using $destroy. so on $destroy function i am calling remove() function to properly dispose.
Is there any other alternative available in nicescroll plugin similar to remove(), does same functionality?

But, i found that in earlier versions(3.5.1V) there is no undelegate function. now it is trying to get delegate['resize'] in undelegate() which doesn't exist. because of that error is coming.

@inuyaksa
Copy link
Owner Author

Do you check using last release 3.7.6 ? (beware of the cache)

@pandu5164
Copy link

pandu5164 commented Jul 21, 2017 via email

@pandu5164
Copy link

pandu5164 commented Jul 22, 2017

railerror on mouse move in normal laptops-chrome browser2
railerror on mouse move in normal laptops-chrome browser

Now i am getting the following error with the latest code..while testing..any idea about this please let me know the fix?

@inuyaksa
Copy link
Owner Author

On which browser and system issue happen?

@pandu5164
Copy link

pandu5164 commented Jul 24, 2017 via email

@pandu5164
Copy link

pandu5164 commented Jul 25, 2017

adding null check at 2 places resolves issue for me.. Please check the below screenshots for changes I made in plugin. Please correct me if doing this is wrong.

capture1
capture2

Thankyou.

@inuyaksa
Copy link
Owner Author

Very strange situation.
You fix could work but there is another big problem, remove don't unbind all events, I presume for your issue.
Please send me a screenshot of this page using yout chrome browser:
https://nicescroll.areaaperta.com/dojo2/browser.html

@pandu5164
Copy link

pandu5164 commented Jul 26, 2017 via email

@inuyaksa
Copy link
Owner Author

It seems screenshot is missing.

@pandu5164
Copy link

capture

Hi, Please find screenshot here.. Actually i am sending image through gmail. I think it is not getting attached if i send image through gmail.. Anyways..please find image here.
Thankyou..

@inuyaksa
Copy link
Owner Author

inuyaksa commented Aug 2, 2017

I found chrome has similar issues on windows 7 in the past.
I think it's a local issue about your SO/browser and "some" software.
I prefer not make a patch for this situation, because it could interfere with other browser/OS in unpredictable manner.
I suggest you to update chrome, there is a change problem solved.

@elarmando
Copy link

Any workaround for this? i got the same issue. Thanks.

@elarmando
Copy link

This change is working for me, hope it helps:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants