Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for CSV to 0.9, (keep existing compat) #121

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 9, 2021

This pull request changes the compat entry for the CSV package from 0.6, 0.7, 0.8 to 0.6, 0.7, 0.8, 0.9.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@rofinn rofinn force-pushed the compathelper/new_version/2021-09-09-00-36-39-787-03939581788 branch from 57d8a4f to 87f83aa Compare September 9, 2021 00:36
@rofinn
Copy link
Member

rofinn commented Oct 6, 2021

Looks like CSV 0.9 doesn't precompile on x86 anymore. I'm inclined to just merge this and hopefully a patch release for 0.9 gets released that fixes the issue. I suppose we could also allow failures depending on the time frame...

JuliaData/CSV.jl#913

@rofinn rofinn merged commit c21aa76 into master Oct 6, 2021
@rofinn rofinn deleted the compathelper/new_version/2021-09-09-00-36-39-787-03939581788 branch October 6, 2021 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant