Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Define ≈ operator for Intervals #152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Define ≈ operator for Intervals #152

wants to merge 2 commits into from

Conversation

gxyd
Copy link

@gxyd gxyd commented Dec 1, 2020

Fixes #150

Still need to think about tests for Unbound intervals.

@gxyd gxyd requested a review from omus as a code owner December 1, 2020 09:26
@gxyd gxyd changed the title Define ≈ operator for Intervals [WIP] Define ≈ operator for Intervals Dec 1, 2020
@gxyd
Copy link
Author

gxyd commented Dec 1, 2020 •
edited
Loading

I didn't expect the below behavior in Julia:

julia> (1 + 1e-10) ≈ 1
true
julia> 1e-10 ≈ 0
false

Is the second answer expected to be false?

[EDIT]

Looking at the code of isapprox it does seem intentional though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omus omus Awaiting requested review from omus omus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define ≈ operator for Intervals
1 participant
@gxyd