installation: dojson dependency bump #49
installation: dojson dependency bump #49
Conversation
tiborsimko
commented
Feb 14, 2017
- ae6f580 tests: pinning example application dependencies
- b04bcad installation: dojson dependency bump
* Bumps the `dojson` dependency to the newly released 1.3.0 version. Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
cab0c0a
to
04de41d
Compare
examples/app.py
Outdated
@@ -62,7 +62,7 @@ | |||
cd static | |||
npm install | |||
cd .. | |||
npm install -g node-sass clean-css requirejs uglify-js | |||
npm install -g node-sass@3.8.0 clean-css@3.4.24 requirejs uglify-js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to not pin clean css and instead install clean-css-cli plus bump invenio-assets to latest beta release. Anyway, not a blocker for integration, but should try to avoid pinning clean css everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tried several weeks ago, using clean-css-cli
wasn't enough... but I can retry with the latest invenio-assets
and stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, judging from inveniosoftware/invenio#3737 (comment) it's actually probably not fully sorted yet due to cleancss
vs cleancssurl
filters. So either we get the filters fixed in the package (e.g. search) or a new webassets package will have it fixed as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lnielsen: Pinnig yields to a successfull build.
docker-compose up -d
works as well
Unfortunately the loading of datasets fails
docker-compose run --rm web ./scripts/populate-instance.sh
Creating database postgresql+psycopg2://invenio3:dbpass123@postgresql:5432/invenio3
Creating all tables!
[####################################] 100%
Created all tables!
User created successfully.
{'active': True, 'password': '****', 'email': u'info@inveniosoftware.org'}
9c410f9c-7d48-406f-a62b-1a4ddc365ef9
9c7e11b7-8a9c-4556-810f-31cb043203b5
331800e8-89b8-4517-8afe-087c01758763
010b5eef-36f4-44ee-97ea-9b2f1e71557d
b7e60021-853e-4503-b4f7-460f4954573d
bb439636-64a4-467e-9ebd-c837871286fb
67d1ff72-83df-4cb9-8b61-aac17bebe971
e09c3f4c-cb8a-41ae-86f3-947a9a1f89d6
cd1ade4e-ef4b-4524-a227-579edd5f6913
Traceback (most recent call last):
File "/home/invenio/.virtualenvs/invenio3/bin/invenio3", line 11, in
load_entry_point('invenio3', 'console_scripts', 'invenio3')()
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/click/core.py", line 722, in call
return self.main(*args, **kwargs)
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/flask/cli.py", line 374, in main
return AppGroup.main(self, *args, **kwargs)
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/flask/cli.py", line 251, in decorator
return ctx.invoke(f, *args, **kwargs)
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/invenio_records/cli.py", line 117, in create
click.echo(Record.create(record, id=id).id)
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/invenio_records/api.py", line 193, in create
record.validate(**kwargs)
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/invenio_records/api.py", line 140, in validate
return _records_state.validate(self, self['$schema'], **kwargs)
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/invenio_records/ext.py", line 58, in validate
**kwargs
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/jsonschema/validators.py", line 541, in validate
cls(schema, *args, **kwargs).validate(instance)
File "/home/invenio/.virtualenvs/invenio3/lib/python2.7/site-packages/jsonschema/validators.py", line 130, in validate
raise error
jsonschema.exceptions.ValidationError: [u'ALEPH Collaboration'] is not of type u'string'Failed validating u'type' in schema[u'allOf'][9][u'properties'][u'added_entry_corporate_name'][u'items'][u'properties'][u'miscellaneous_information']:
{u'type': u'string'}On instance[u'added_entry_corporate_name'][0][u'miscellaneous_information']:
[u'ALEPH Collaboration']
and the webserver gives an internal Server error when trying to search
I do not know whether this is related to the search package problem ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lnielsen Yes, I got into troubles with webassets
, which may take unknown time to release hte fix, so I'm rolling back to pinning the dependencies.
@martinkoehler Please stay tuned, once I sort this out, I'll update also the Invenio demo site.
2096353
to
e428723
Compare
* Makes example application to work again by pinning `node-sass` and `clean-css` dependencies and by upgrading the `invenio-assets` etc dependencies and by modifying the example application with respect to `invenio-i18n`. * Upgrades Sphinx minimal version to 1.5.2. Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
e428723
to
f721f2a
Compare
@jirikuncar @lnielsen Please note the latest commit in this PR -- 09e98fc "tests: doctext execution simplification" -- which seems to be the cleanest way how to solve the Travis CI troubles observed with the development dependencies. Is there any particular reason why sphinx-build doctesting was done kind of "twice" in P.S. Note that @jirikuncar already amended |
* Performs doctest execution within the initial pytest run, simplifying test suite and solving "disappearing development requirements" when trying the requirements-builder's development level. * Amends test suite code to be inside the test application context in order to assist the pytest doctest discovery. Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
c46f421
to
09e98fc
Compare
@tiborsimko I don't remember any specific reason why it was like that except that pytest did the unit tests and sphinx did the doctests, but it makes fully sense to me to let pytest do everything. |