Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib: update github login and fix orcid disconnect #54

Merged
merged 1 commit into from
Jun 14, 2016
Merged

contrib: update github login and fix orcid disconnect #54

merged 1 commit into from
Jun 14, 2016

Conversation

hachreak
Copy link
Member

@hachreak hachreak commented Jun 1, 2016 •
edited
Loading

  • Fix github info retrieval.
  • Fix orcid disconnection.
  • Rely on github id instead of github primary email.
  • Signup through security form.
  • Prefill signup form.
  • Force github registration through signup form.
  • Makes signup form template configurable.

Signed-off-by: Leonardo Rossi leonardo.r@cern.ch

@coveralls
Copy link

coveralls commented Jun 1, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 76.73% when pulling ca1dde8 on hachreak:fix_github into 869beb5 on inveniosoftware:master.

@hachreak hachreak force-pushed the fix_github branch 2 times, most recently from 8d51f3c to 2794ff9 Compare June 1, 2016 15:18
@hachreak
Copy link
Member Author

hachreak commented Jun 1, 2016

ping @lnielsen

@hachreak hachreak force-pushed the fix_github branch 2 times, most recently from d6a6976 to 4645082 Compare June 1, 2016 15:24
@coveralls
Copy link

coveralls commented Jun 1, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 76.73% when pulling 4645082 on hachreak:fix_github into 869beb5 on inveniosoftware:master.

@coveralls
Copy link

coveralls commented Jun 1, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 76.73% when pulling d6a6976 on hachreak:fix_github into 869beb5 on inveniosoftware:master.

@coveralls
Copy link

coveralls commented Jun 1, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 76.73% when pulling 4645082 on hachreak:fix_github into 869beb5 on inveniosoftware:master.

@coveralls
Copy link

coveralls commented Jun 2, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 76.73% when pulling 7474b98 on hachreak:fix_github into 869beb5 on inveniosoftware:master.

@coveralls
Copy link

coveralls commented Jun 2, 2016 •
edited
Loading

Coverage Status

Coverage increased (+2.7%) to 79.381% when pulling 44cf2e4 on hachreak:fix_github into 869beb5 on inveniosoftware:master.

lnielsen
lnielsen reviewed Jun 2, 2016
View reviewed changes
setup.py
@@ -92,6 +92,7 @@
'Flask-OAuthlib>=0.6.0,<0.7', # quick fix for issue invenio#2158
'Flask-Security>=1.7.5',
'invenio-accounts>=1.0.0a6',
'invenio-db>=1.0.0a9',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is already present in extra_requie. You just have to install with pip install -e .[all,postgresql]

@coveralls
Copy link

coveralls commented Jun 2, 2016 •
edited
Loading

Coverage Status

Coverage increased (+2.7%) to 79.381% when pulling 74a691a on hachreak:fix_github into 869beb5 on inveniosoftware:master.

@hachreak hachreak mentioned this pull request Jun 2, 2016
Closed
@hachreak hachreak force-pushed the fix_github branch 2 times, most recently from c6f9f1b to 72981a8 Compare June 2, 2016 14:54
@hachreak hachreak changed the title contrib: update github login contrib: update github login and fix orcid disconnect Jun 2, 2016
lnielsen
lnielsen reviewed Jun 2, 2016
View reviewed changes
examples/github_app.py
@@ -82,13 +84,14 @@

from flask import Flask, redirect, url_for
from flask_babelex import Babel
from flask_cli import FlaskCLI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still needed for Flask==0.10.x

@lnielsen lnielsen added this to the v1.0.0 milestone Jun 2, 2016
@coveralls
Copy link

coveralls commented Jun 2, 2016 •
edited
Loading

Coverage Status

Coverage increased (+2.6%) to 85.349% when pulling 72981a8 on hachreak:fix_github into 3f7f089 on inveniosoftware:master.

@coveralls
Copy link

coveralls commented Jun 2, 2016 •
edited
Loading

Coverage Status

Coverage increased (+2.6%) to 85.349% when pulling dcdeee0 on hachreak:fix_github into 3f7f089 on inveniosoftware:master.

@hachreak hachreak force-pushed the fix_github branch 2 times, most recently from 48e7922 to 4364fc9 Compare June 7, 2016 15:09
@hachreak
Copy link
Member Author

hachreak commented Jun 7, 2016

ping @lnielsen
(see the second commit for latest changes)

@coveralls
Copy link

coveralls commented Jun 7, 2016 •
edited
Loading

Coverage Status

Coverage increased (+3.3%) to 86.043% when pulling 1b5a6b3 on hachreak:fix_github into 3f7f089 on inveniosoftware:master.

@coveralls
Copy link

coveralls commented Jun 7, 2016 •
edited
Loading

Coverage Status

Coverage increased (+3.3%) to 86.024% when pulling 4364fc9 on hachreak:fix_github into 3f7f089 on inveniosoftware:master.

jirikuncar
jirikuncar reviewed Jun 7, 2016
View reviewed changes
invenio_oauthclient/templates/invenio_oauthclient/signup.html
{%- block signup_app_icon %}
{% if app_icon -%}
<span class="pull-right"><i class="{{app_icon}} fa-5x"></i></span>
{%- endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check the indentation here?

@coveralls
Copy link

coveralls commented Jun 7, 2016 •
edited
Loading

Coverage Status

Coverage increased (+3.3%) to 86.024% when pulling 4364fc9 on hachreak:fix_github into 3f7f089 on inveniosoftware:master.

@coveralls
Copy link

coveralls commented Jun 8, 2016 •
edited
Loading

Coverage Status

Coverage increased (+3.3%) to 86.024% when pulling 2dc7cd0 on hachreak:fix_github into 3f7f089 on inveniosoftware:master.

@coveralls
Copy link

coveralls commented Jun 8, 2016 •
edited
Loading

Coverage Status

Coverage increased (+3.3%) to 86.043% when pulling 4f3781e on hachreak:fix_github into 3f7f089 on inveniosoftware:master.

@coveralls
Copy link

coveralls commented Jun 8, 2016 •
edited
Loading

Coverage Status

Coverage increased (+3.3%) to 86.043% when pulling 5a43bf0 on hachreak:fix_github into 3f7f089 on inveniosoftware:master.

@hachreak hachreak force-pushed the fix_github branch 2 times, most recently from 1d2a0ab to 43ee955 Compare June 8, 2016 08:41
@coveralls
Copy link

coveralls commented Jun 8, 2016 •
edited
Loading

Coverage Status

Coverage increased (+3.3%) to 86.043% when pulling 1d2a0ab on hachreak:fix_github into 3f7f089 on inveniosoftware:master.

@coveralls
Copy link

coveralls commented Jun 8, 2016 •
edited
Loading

Coverage Status

Coverage increased (+3.3%) to 86.043% when pulling 43ee955 on hachreak:fix_github into 3f7f089 on inveniosoftware:master.

@lnielsen
Copy link
Member

@hachreak Can you take a look why the tests are not passing.

@hachreak
Copy link
Member Author

ok, I'll take a look

contrib: update orcid and github login
62b1ca6 
* Fixes github info retrieval.

* Fixes orcid disconnection.

* Relies on github id instead of github primary email.

* Uses signup security form.

* Adds prefill for signup form.

* Forces github registration through signup form.

* Makes signup form template configurable.

Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
@coveralls
Copy link

coveralls commented Jun 13, 2016 •
edited
Loading

Coverage Status

Coverage increased (+3.3%) to 85.986% when pulling 62b1ca6 on hachreak:fix_github into 3f7f089 on inveniosoftware:master.

@hachreak
Copy link
Member Author

ping @lnielsen

@lnielsen lnielsen merged commit 62b1ca6 into inveniosoftware:master Jun 14, 2016
@hachreak hachreak deleted the fix_github branch June 21, 2016 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jirikuncar jirikuncar

@hachreak hachreak

@lnielsen lnielsen

Labels
Type: enhancement
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hachreak @coveralls @lnielsen @jirikuncar @switowski