controllers: adds $schema to payload #23
Conversation
Signed-off-by: Pamfilos Fokianos <pamfilosf@gmail.com>
| @@ -185,6 +185,7 @@ function InvenioRecordsCtrl($scope, $rootScope, $q, $window, $location, | |||
| url: vm.invenioRecordsEndpoints[type], | |||
| method: (method || 'PUT').toUpperCase(), | |||
| data: { | |||
| '$schema': vm.invenioRecordsEndpoints.schema, | |||
There was a problem hiding this comment.
No.. For it to work now it should be on the same level as metadata, not inside
|
We need to refactor how the JSON payload is provided. E.g. adding @drjova Any ideas for how best to solve it? |
|
Additionally, since we're soon to release Zenodo, we probably need two branches (maint/master, master/next), so that we don't block each other. |
|
Superseded by f0c65e2 you can now add additional data to the payload by using the existing <invenio-records
extra-params='{"headers": {"foo": "bar"}, "data": {"$schema": "foofoo"}}'
>
</invenio-records>With that fix you it'll work exactly as it is on |
|
@drjova But I think the problem is as well that it's adding the |
|
@lnielsen hmm we have it already there https://github.com/inveniosoftware/invenio-records-js/blob/master/src/invenio-records-js/controllers/InvenioRecordsCtrl.js#L187-L189 I'll make it configurable |
|
superseded by #24 |
Signed-off-by: Pamfilos Fokianos pamfilosf@gmail.com