Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

BatchUploader: allow insertion of text MARC #1023

Open
jeromecaffaro opened this Issue · 2 comments

3 participants

jeromecaffaro Javier Martin Montull Lars Holm Nielsen
jeromecaffaro
Collaborator

Originally on 2012-04-25

Batchuploader interface allows to "--insert" "TextMarc" records, but the underlying textmarc2xmlmarc.py will not support the creation of MARCXML without a record ID (tag 001), which is necessary to avoid when inserting records (and not updating/replacing).

  • The textmarc2xmlmarc.py could be enhanced to support input MARC without recid (a fake prefixing recid would still be needed in the input to differentiate records)
  • batchuploader_engine.py could strip off the recid created by textmarc2xmlmarc.py if it is run in "--insert" mode
  • The "--insert" option could be removed from web interface when "TextMARC" record is selected (and "TextMARC" removed when "--insert" is selected)
Javier Martin Montull jmartinm was unassigned by jeromecaffaro
jeromecaffaro jeromecaffaro self-assigned this
Javier Martin Montull
Collaborator

Originally on 2013-05-16

Commits

7949e5658fe0713201501f9f0742795ee27d1c02
545d9bf3de05ffbc3e16ffab057c3c0127aa2a4a

in branch jmartinm/rebase-master-batchuploader-multiedit

address this problem. Could you review the code?

jeromecaffaro
Collaborator

Originally on 2013-05-21

Reviewed code and tested successfully (as far as this ticket is concerned, i.e. not including other commits in the branch).

Note the following line in commit 16612d9:

+>>>>>>> e0af3b3... BatchUploader: dynamic size for input of email logs to

You can also maybe add the directive Closes #1023 in the commit log.

Lars Holm Nielsen lnielsen added the master label
jeromecaffaro jeromecaffaro was unassigned by lnielsen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.