New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BibDocFile: Escaping characters in Document Files Manager #1918
Comments
CC-ing @ludmilamarian; see also somewhat related #2067. |
switowski
pushed a commit
to switowski/invenio
that referenced
this issue
Feb 17, 2015
* Disallows % character in filenames since it may cause some problems with URL encoding/decoding leading to incorrect URLs. (addresses inveniosoftware#1918)
switowski
pushed a commit
to switowski/invenio
that referenced
this issue
Feb 17, 2015
* Disallows % character in filenames since it may cause some problems with URL encoding/decoding leading to incorrect URLs. (addresses inveniosoftware#1918) Signed-off-by: Sebastian Witowski <sebastian.witowski@cern.ch>
switowski
pushed a commit
to CERNDocumentServer/invenio
that referenced
this issue
May 8, 2015
* Disallows % character in filenames since it may cause some problems with URL encoding/decoding leading to incorrect URLs. (addresses inveniosoftware#1918) Signed-off-by: Sebastian Witowski <sebastian.witowski@cern.ch>
switowski
pushed a commit
to CERNDocumentServer/invenio
that referenced
this issue
Jun 1, 2015
* Disallows % character in filenames since it may cause some problems with URL encoding/decoding leading to incorrect URLs. (addresses inveniosoftware#1918) Signed-off-by: Sebastian Witowski <sebastian.witowski@cern.ch>
switowski
pushed a commit
to CERNDocumentServer/invenio
that referenced
this issue
Jun 26, 2015
* Disallows % character in filenames since it may cause some problems with URL encoding/decoding leading to incorrect URLs. (addresses inveniosoftware#1918) Signed-off-by: Sebastian Witowski <sebastian.witowski@cern.ch>
switowski
pushed a commit
to CERNDocumentServer/invenio
that referenced
this issue
Jul 24, 2015
* Disallows % character in filenames since it may cause some problems with URL encoding/decoding leading to incorrect URLs. (addresses inveniosoftware#1918) Signed-off-by: Sebastian Witowski <sebastian.witowski@cern.ch>
switowski
pushed a commit
to CERNDocumentServer/invenio
that referenced
this issue
Sep 1, 2015
* Disallows % character in filenames since it may cause some problems with URL encoding/decoding leading to incorrect URLs. (addresses inveniosoftware#1918) Signed-off-by: Sebastian Witowski <sebastian.witowski@cern.ch>
egabancho
pushed a commit
to CERNDocumentServer/invenio
that referenced
this issue
Mar 10, 2016
* Disallows % character in filenames since it may cause some problems with URL encoding/decoding leading to incorrect URLs. (addresses inveniosoftware#1918) Signed-off-by: Sebastian Witowski <sebastian.witowski@cern.ch>
tiborsimko
pushed a commit
to tiborsimko/invenio
that referenced
this issue
Nov 24, 2016
* FIX Disallows % character in filenames since it may cause some problems with URL encoding/decoding leading to incorrect URLs. (closes inveniosoftware#1918) (PR inveniosoftware#2788) Signed-off-by: Sebastian Witowski <sebastian.witowski@cern.ch>
Closed by #3729. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
yesterday I've noticed that there is a bug in the Document File Manager that allows user to upload a file with /,(,),. characters in the file name encoded using URL-encoding, for example "art%3A10.1007%2FJHEP01%282013%29057.pdf".
Aside from the fact that if those characters weren't encoded, Document File Manager wouldn't allow to upload files like that (at least not with front-slash in the file name), after a user uploads a file like that then we can have multiple problems:
Stage 2B failed: ERROR: while synchronizing 8564 tags: invalid literal for int() with base 10: '12345678/art:10.1007
. It's caused by this functiondecompose_file(urllib.unquote(recid_file))
/record/12345678/files/art:10.1007/JHEP01(2013)057.pdf
and that returns 404 instead of a file).Tibor mentioned that someone was already working on patching that ?
The text was updated successfully, but these errors were encountered: