Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

WebStat: renaming a column in webstat.cfg deletes the column #546

Closed
jeromecaffaro opened this Issue · 9 comments

3 participants

@jeromecaffaro
Collaborator

Originally on 2011-03-08

When renaming a column in webstat.cfg and running ./webstatadmin --load-config,
the column is deleted from the database instead of being renamed, losing the information previously logged.

It would be safer that the column is renamed instead of being "replaced".

@tiborsimko
Owner

Originally on 2011-04-12

This commit builds on top of another commit that has issues like
909C4p being replaced by 773__p. The demo markup uses 909C4p
precisely so that things like this are configurable... The correct
field to use is 909C4 for the demo markup, while 773 for CDS markup.
So we cannot do such a change globally, it must be made configurable.
More comments IRL.

@invenio-developers
Collaborator

Originally by Carmen Alvarez Perez carmen.alvarez.perez@cern.ch on 2011-11-16

In [5cfe726]:

#CommitTicketReference repository="" revision="5cfe726a1e0676dfd858198bec589fe7cddae541"
WebStat: minor improvements

- When renaming a column in webstat.cfg and running ./webstatadmin --load-config,
  the column was deleted from the database. Now, the user is asked if he wants to
  delete it or rename it (fixes #546)
* Change line graphs to bar graphs
* Add average, max and min values for events
* Fix total records count now also counts restricted collections
* Clean up code
* Improve display of data when selecting last 2, 5 or 10 years
* Change names of bibcirculation stats
@tiborsimko
Owner

Originally on 2011-11-16

Reopening this ticket, because the above comment:2 related to 909C4 vs 773 was not addressed... slipped during merge.

@invenio-developers
Collaborator

Originally by calvarez on 2012-01-12

Replying to [comment:5 simko]:

Reopening this ticket, because the above comment:2 related to 909C4 vs 773 was not addressed... slipped during merge.

It was fixed in this commit: http://invenio-software.org/repo/invenio/commit/?id=ea5536211192ac35b81615a73a8d8acdb7611b7f

  • Fix custom query summary (use CFG_JOURNAL_TAG variable)
@tiborsimko
Owner

Originally on 2012-01-20

Replying to [comment:7 calvarez]:

It was fixed in this commit:

Actually, it wasn't fixed in that commit. The commit you mention was merged back in November as [ea55362] already, and while it addresses the 773/909C4 issue, it does not fixes it completely. Which is why I reopened this ticket.

$ git grep -C 1 773 modules/webstat/lib/
modules/webstat/lib/webstat.py-    if args['tag'] == '':
modules/webstat/lib/webstat.py:        args['tag'] = "773__p"
modules/webstat/lib/webstat.py-    data = get_custom_summary_data(args['query'], args['tag'])
@invenio-developers
Collaborator

Originally by Carmen Alvarez Perez carmen.alvarez.perez@cern.ch on 2013-03-05

In 337bcc7:

#CommitTicketReference repository="invenio" revision="337bcc726b3b6d6801edf49582911ad09fe082b8"
WebStat: use CFG_JOURNAL_TAG instead of 773/909C4

- Uses configurable journal tag (CFG_JOURNAL_TAG)
  instead of hard-coded 773/909C4.  (closes #546)

Reviewed-by: Tibor Simko <tibor.simko@cern.ch>
@invenio-developers
Collaborator

Originally by Carmen Alvarez Perez carmen.alvarez.perez@cern.ch on 2013-03-05

In 337bcc7:

#CommitTicketReference repository="invenio" revision="337bcc726b3b6d6801edf49582911ad09fe082b8"
WebStat: use CFG_JOURNAL_TAG instead of 773/909C4

- Uses configurable journal tag (CFG_JOURNAL_TAG)
  instead of hard-coded 773/909C4.  (closes #546)

Reviewed-by: Tibor Simko <tibor.simko@cern.ch>
@invenio-developers
Collaborator

Originally by Carmen Alvarez Perez carmen.alvarez.perez@cern.ch on 2013-03-05

In 337bcc7:

#CommitTicketReference repository="invenio" revision="337bcc726b3b6d6801edf49582911ad09fe082b8"
WebStat: use CFG_JOURNAL_TAG instead of 773/909C4

- Uses configurable journal tag (CFG_JOURNAL_TAG)
  instead of hard-coded 773/909C4.  (closes #546)

Reviewed-by: Tibor Simko <tibor.simko@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.