Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Strong Tags broken in generic case #939

Closed
invenio-developers opened this Issue · 5 comments

2 participants

@invenio-developers
Collaborator

Originally by adeiana (@Osso) on 2012-03-08

I am trying to use CFG_BIBUPLOAD_STRONG_TAGS for the tag 999

However copy_strong_tags_from_old_record is checking for fields with
record_get_field_instances(rec_old, strong_tag)
In my case this never gets any result because references have subfields set.
I would replace it with
record_get_field_instances(rec_old, strong_tag, '%', '%')

@kaplun
Collaborator

Originally on 2012-04-12

Indeed we should take care of correctly handling the presence or absence of ind1 and ind2 in the tag specified by CFG_BIBUPLOAD_STRONG_TAGS.

@kaplun
Collaborator

Originally on 2013-02-11

The attached patch implement the proposal for maint-1.0 on-wards.

@kaplun kaplun closed this
@kaplun
Collaborator

Originally on 2013-08-14

In 6999ab1:

#CommitTicketReference repository="invenio" revision="6999ab19979bb50a7931bb1242f3f5671fe697e8"
BibUpload: indicators in strong tags

- So far CFG_BIBUPLOAD_STRONG_TAGS config variable assumed strong
  tags had empty indicator. This was causing tags such as 999C0
  to never be matched. The new implementation assume strong tags
  specify also indicators. If they are not specified, then '%' is
  ussumed for ind1 and ind2.
  (closes #939)

Reported-by: Alessio Deiana <alessio.deiana@cern.ch>
Reviewed-by: Tibor Simko <tibor.simko@cern.ch>
@kaplun
Collaborator

Originally on 2013-08-14

In 6999ab1:

#CommitTicketReference repository="invenio" revision="6999ab19979bb50a7931bb1242f3f5671fe697e8"
BibUpload: indicators in strong tags

- So far CFG_BIBUPLOAD_STRONG_TAGS config variable assumed strong
  tags had empty indicator. This was causing tags such as 999C0
  to never be matched. The new implementation assume strong tags
  specify also indicators. If they are not specified, then '%' is
  ussumed for ind1 and ind2.
  (closes #939)

Reported-by: Alessio Deiana <alessio.deiana@cern.ch>
Reviewed-by: Tibor Simko <tibor.simko@cern.ch>
@kaplun
Collaborator

Originally on 2013-08-14

In 6999ab1:

#CommitTicketReference repository="invenio" revision="6999ab19979bb50a7931bb1242f3f5671fe697e8"
BibUpload: indicators in strong tags

- So far CFG_BIBUPLOAD_STRONG_TAGS config variable assumed strong
  tags had empty indicator. This was causing tags such as 999C0
  to never be matched. The new implementation assume strong tags
  specify also indicators. If they are not specified, then '%' is
  ussumed for ind1 and ind2.
  (closes #939)

Reported-by: Alessio Deiana <alessio.deiana@cern.ch>
Reviewed-by: Tibor Simko <tibor.simko@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.