Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanitation for SVG attachments #3701

Merged
merged 5 commits into from
Sep 23, 2022

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Sep 21, 2022

This PR adds sanitation for SVG files.

See huntr

@matmair matmair added enhancement This is an suggested enhancement or new feature security Relates to a security issue labels Sep 21, 2022
@matmair matmair added this to the 0.8.3 milestone Sep 21, 2022
@matmair matmair self-assigned this Sep 21, 2022
@SchrodingersGat
Copy link
Member

Nice, this looks very clean. Is there a simple unit test (i.e. a dodgy svg file) we could throw at it?

@matmair
Copy link
Contributor Author

matmair commented Sep 21, 2022

@SchrodingersGat I will add some tests once the CI is run through

@SchrodingersGat
Copy link
Member

@matmair friendly bump that CI has passed here :)

@matmair
Copy link
Contributor Author

matmair commented Sep 23, 2022

@SchrodingersGat was already writing them - those should be enough for now.

@SchrodingersGat SchrodingersGat merged commit 5a08ef9 into inventree:master Sep 23, 2022
@SchrodingersGat SchrodingersGat deleted the sec-svg-xss branch September 23, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature security Relates to a security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants