Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pfdhcp no roaring #3779

Merged
merged 6 commits into from Nov 13, 2018
Merged

Feature/pfdhcp no roaring #3779

merged 6 commits into from Nov 13, 2018

Conversation

julsemaan
Copy link
Collaborator

Description

Stop using roaring bitmap for DHCP pool tracking as requested by the Febreeze

Impacts

pfdhcp

Delete branch after merge

YES

@satkunas
Copy link
Contributor

satkunas commented Nov 12, 2018

🦁...

@extrafu
Copy link
Member

extrafu commented Nov 12, 2018

👃 this PR smells pretty good.

@fdurand
Copy link
Member

fdurand commented Nov 12, 2018

Looks good to me.
Just need to remove the raoring comments in the code.

@fdurand fdurand merged commit 21a4903 into devel Nov 13, 2018
fdurand added a commit that referenced this pull request Nov 13, 2018
@fdurand fdurand deleted the feature/pfdhcp-no-roaring branch November 13, 2018 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants