Automation of upgrades for standalone servers #6583
Conversation
|
Leaving a note here for the hooks logic, will need to discuss this with @nqb and the rest of the team: I added a logic to allow defining hooks in The content of this directory should be managed by a seperate package built on maintenance/X.Y and do-upgrade.sh will have to upgrade it before running the "real" upgrade process |
julsemaan
force-pushed
the
feature/automate-upgrades
branch
from
152e358
to
14b2ad9
Compare
nqb
force-pushed
the
feature/automate-upgrades
branch
from
7622af6
to
2d62841
Compare
|
Packages |
|
@nqb, I've performed the adjustments based on our discussion, it should be ready for packaging |
|
@satkunas, could you look at the conflicting files (related to frontend) ? |
| elif is_deb_based; then | ||
| OS="Debian-11" | ||
| fi | ||
| curl https://www.packetfence.org/downloads/PacketFence/latest-stable-$OS.txt |
There was a problem hiding this comment.
If suggest to do a GitHub API call to get latest stable based on stable tag.
We decided to not use it anymore but it could be interested to use it for that purpose.
There was a problem hiding this comment.
The thing is the stable tag will differ for RHEL8 and RHEL9 when we get there so we'd need a stable-rhel8 stable-debian11, etc
By putting it in a file here, we're able to stop updating the stable release when we switch OS
There was a problem hiding this comment.
I understand your idea and your approach. I will see if I can automate update of these two files when we will release.
There was a problem hiding this comment.
That would indeed be the goal, the release pipeline should be performing this, not one of us manually
There was a problem hiding this comment.
Should be ready now. I will run a pipeline and see if it works. Meanwhile, could you add support to pull latest-devel-$OS-txt when we are testing on devel or on development branches ?
There was a problem hiding this comment.
Pipeline triggered with BUILD_ARTIFACTS_WEBSITE=yes:
https://gitlab.com/inverse-inc/packetfence/-/pipelines/382749074
It should create latest-devel-$OS.txt files.
|
@julsemaan, as discussed together, please add following features:
|
|
@julsemaan, another thing that came to my mind and which is related to #6468, is it possible to perform upgrade in a non-interactive way ? I see that you use some environment variables to avoid asking questions but I didn't test completely. |
It is possible to do this indeed |
- for EL: packetfence-release pkg - for Debian : packetfence-archive-keyring pkg packetfence main package is now dependent to each of this package. having gpg or gnupg2 is necessary to install packetfence too
nqb
force-pushed
the
feature/automate-upgrades
branch
from
b47d282
to
bb4e5e9
Compare
maintenance is not supported
|
@fdurand, can you take a look at this to make sure it makes sense and we'll be ready to merge, we'll do the doc post-merge |
|
Waiting end of https://gitlab.com/inverse-inc/packetfence/-/pipelines/382848646 to confirm |
Its in its own file actually: https://github.com/inverse-inc/packetfence/blob/bcaf91b9c9947ff149ee82b7ca204a6508665f72/lib/pf/cmd/pf/generatemonitconfig.pm |
it´s just to have the output when you do a bin/pfcmd |
|
Ready to merge on my side. I will let @fdurand and @julsemaan provide their inputs before merging. |
Not sure which symlink you're talking about |
you need to have a symbolic link between the file and the debian directory
My bad it´s useless since you are not using dh_installinit |
|
it´s ok on my side to merge |
Related to #6583 Necessary for Perl unit tests.
NOT READY
Missing:
See Automation of upgrades for standalone servers #6583 (comment) for details
Description
Allows to upgrade a standalone server via a single script that performs the whole upgrade
Impacts
We won't need @lzammit to do the upgrades anymore
Delete branch after merge
YES
Checklist
(REQUIRED) - [yes, no or n/a]
NEWS file entries
TODO