From 008b35affc27d443fcc80908c29f7b67b5998e85 Mon Sep 17 00:00:00 2001 From: russellwheatley Date: Thu, 29 Feb 2024 08:40:04 +0000 Subject: [PATCH] fix: ensure upload-symbol script works for every build type --- .../lib/src/commands/upload_symbols.dart | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/packages/flutterfire_cli/lib/src/commands/upload_symbols.dart b/packages/flutterfire_cli/lib/src/commands/upload_symbols.dart index e9158359..0b20230e 100644 --- a/packages/flutterfire_cli/lib/src/commands/upload_symbols.dart +++ b/packages/flutterfire_cli/lib/src/commands/upload_symbols.dart @@ -359,7 +359,8 @@ class UploadCrashlyticsSymbols extends FlutterFireCommand { ], environment: { 'PLATFORM_NAME': envPlatformName, - 'CONFIGURATION': envConfiguration, + // Hard code "Release" to ensure "App.framework.dsym" is uploaded and complies with upload-symbol script + 'CONFIGURATION': 'Release', 'PROJECT_DIR': envProjectDir, 'DWARF_DSYM_FOLDER_PATH': envDwarfDsymFolderPath, 'DWARF_DSYM_FILE_NAME': envDwarfDsymFileName, @@ -371,15 +372,6 @@ class UploadCrashlyticsSymbols extends FlutterFireCommand { if (validationScript.exitCode != 0) { throw Exception(validationScript.stderr); } - print('uploadSymbolsScriptPath: $uploadSymbolsScriptPath'); - print('appIdFilePath: $appIdFilePath'); - print('envPlatformName: $envPlatformName'); - print('envConfiguration: $envConfiguration'); - print('envProjectDir: $envProjectDir'); - print('envDwarfDsymFolderPath: $envDwarfDsymFolderPath'); - print('envDwarfDsymFileName: $envDwarfDsymFileName'); - print('envInfoPlistPath: $envInfoPlistPath'); - print('envBuildProductsDir: $envBuildProductsDir'); // Upload script final uploadScript = await Process.run( uploadSymbolsScriptPath, @@ -389,7 +381,8 @@ class UploadCrashlyticsSymbols extends FlutterFireCommand { ], environment: { 'PLATFORM_NAME': envPlatformName, - 'CONFIGURATION': envConfiguration, + // Hard code "Release" to ensure "App.framework.dsym" is uploaded and complies with upload-symbol script + 'CONFIGURATION': 'Release', 'PROJECT_DIR': envProjectDir, 'DWARF_DSYM_FOLDER_PATH': envDwarfDsymFolderPath, 'DWARF_DSYM_FILE_NAME': envDwarfDsymFileName,