Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing consent-library for Admob - GDPR #1133

Closed
CristiTr opened this issue May 24, 2018 · 11 comments

Comments

@CristiTr
Copy link

commented May 24, 2018

Hi guys,

Some of you may have noticed that AdMob now requires to implement the consent-library to get in app consent from users.
(if you are based in the EU this is required for all users)

Google eu-consent documentation:
Android
IOS

On a first look these libraries look buggy, also we know that they were written under a huge time pressure.

Is there any plan to implement the eu-consent library in RNFirebase?

How do you tackle this issue? it has been only a few days since this requirement started showing in AdMob and eCPM dropped immediately to about 30% of the usual rate.

@Ehesp

This comment has been minimized.

Copy link
Member

commented May 28, 2018

Thanks for brining this up, we'll discuss internally about the priority as an admob rework is in the pipeline and this is something which will need consideration.

I've raised it on https://react-native-firebase.canny.io/feature-requests/p/implement-consent-library-admob so we can keep track. Thanks!

@Ehesp Ehesp closed this May 28, 2018

@lwansbrough

This comment has been minimized.

Copy link

commented Jun 12, 2018

+1. If this is a priority or more importantly, a requirement made by AdMob, this library needs to implement it.

@bladefist

This comment has been minimized.

Copy link

commented Jun 12, 2018

Not having the consent sdk likely means users of this repo are leaving a lot of CPM on the table.

@bearty

This comment has been minimized.

Copy link

commented Aug 25, 2018

Do you have any news about implementing GDPR?
I did't find any information in documentation and in "request board" (search and load more not work)

@Salakar

This comment has been minimized.

Copy link
Member

commented Aug 25, 2018

@bearty the board should be fixed now sorry 🙈

@czater

This comment has been minimized.

Copy link

commented Sep 1, 2018

any news?

@Salakar

This comment has been minimized.

Copy link
Member

commented Sep 2, 2018

PR's would be welcome on this, right now we have our hands full.

@djpetenice

This comment has been minimized.

Copy link

commented Feb 28, 2019

Is there any new on this? I've just moved over from react-native-admob which also didn't have the GDPR constent library implemented.

@Salakar

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

This will most likely land as part of v6.

You can track the progression of v6 here: https://github.com/invertase/react-native-firebase/blob/master/CHANGELOG.md


Loving react-native-firebase and the support we provide? Please consider supporting us with any of the below:

@Salakar Salakar added this to the v6.0.0 milestone Feb 28, 2019

@Salakar Salakar added this to ⁉️ To do (Issues/PRs) in React Native Firebase - v6 via automation Feb 28, 2019

@djpetenice

This comment has been minimized.

Copy link

commented Feb 28, 2019

@Salakar thanks for the update 👍

@Salakar Salakar added this to To do (library) in v6 - Release Jul 31, 2019

@Salakar Salakar removed this from ⁉️ To do (Issues/PRs) in React Native Firebase - v6 Jul 31, 2019

@Ehesp

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

Hi All this is in progress and will be part of v6.

@Ehesp Ehesp moved this from To do (library) to Review in progress in v6 - Release Aug 21, 2019

@Ehesp Ehesp moved this from Review in progress to Done in v6 - Release Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
You can’t perform that action at this time.