Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier on index.d.ts & Add auth listener callback type #1689

Merged

Conversation

rakannimer
Copy link
Contributor

Summary

Ran prettier on index.d.ts and added AuthListenerCallback to typescript declaration file and pass it to auth listeners

Checklist

  • Supports Android
  • Supports iOS
  • e2e tests added or updated in /tests/e2e/*
  • Updated the documentation in the docs repo
    • LINK TO DOCS PR HERE
  • Flow types updated
  • Typescript types updated

Release Plan

[TYPES][ENHANCEMENT] [AUTHENTICATION] - Update TS types for auth listeners


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #1689 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1689   +/-   ##
=======================================
  Coverage   75.88%   75.88%           
=======================================
  Files          72       72           
  Lines        1837     1837           
=======================================
  Hits         1394     1394           
  Misses        443      443

@Ehesp Ehesp self-requested a review November 15, 2018 15:06
@rakannimer rakannimer merged commit f2bf9c3 into invertase:master Nov 15, 2018
@rakannimer rakannimer deleted the add-auth-listener-callback-type branch November 15, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants