Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.3.0 #2033

Merged
merged 39 commits into from Apr 9, 2019

Conversation

Projects
None yet
4 participants
@Salakar
Copy link
Member

commented Apr 6, 2019

Titozzz and others added some commits Jan 3, 2019

wip
add NotificationChannel & NotificationChannelGroup serialisation + ad…
…ds support for NotificationChannelGroup.description
@mikehardy

This comment has been minimized.

Copy link
Collaborator

commented Apr 6, 2019

I'm excited to see the Firestore changes required to track upstream even if it's a bit of a sidetrack from what appears to be such solid 6.x progress. The errors related to size in 17.x of firestore, fixed in 18 were a little worrying to me as I'm just about to integrate it to my app. Which is a segue to me offering to test this as I begin working with the firestore APIs starting Monday if you give me some very clear snippet of how exactly to npm install the version to do so (with https+git or an npmjs.com label or something)

@Salakar

This comment has been minimized.

Copy link
Member Author

commented Apr 6, 2019

Hey @mikehardy

I am trying to keep v5 updated as often as I can as I'm aware v6 is some time away, the changes above were definitely needed at least to fix a couple of things, with some minor feature support added just to keep people going 🙃

I'm hoping to have this published to npm by Monday/Monday lunch time, so it'll just be a case of installing v5.3.0 once it's published and following the upgrade guide (still todo but pretty much just update SDK versions).


Firestore v6 work hasn't started properly yet also so it's not too bad doing v5 changes as some of it can be lifted over. Some major internals changes for it in v6, mainly focused at performance improvements - pretty big ones, that's not to say the current implementation is bad, just a lot more performance can be squeezed out of it.

Salakar added some commits Apr 8, 2019

@mikehardy mikehardy referenced this pull request Apr 8, 2019

Closed

firestore get API not working #2037

5 of 34 tasks complete

Salakar added some commits Apr 8, 2019

@mikehardy

This comment has been minimized.

Copy link
Collaborator

commented Apr 8, 2019

@Salakar I read up on security rules, created a fresh empty firestore db for my app over the weekend and am just about to get busy on this so I can start ground up with this new dependency - just tag me when npmjs has it and then (ideally) you will not hear from me because it just works ;-)

@Salakar Salakar changed the title [WIP] v5.3.0 v5.3.0 Apr 8, 2019

@invertase invertase deleted a comment from codecov bot Apr 8, 2019

@Salakar

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

https://rnfirebase.io/docs/v5.3.x/releases/v5.3.x - release notes preview up.

Migrating the starter then I'll publish

@mgenov

This comment has been minimized.

Copy link

commented Apr 8, 2019

Getting a really strange error when trying 5.3.0-rc1 with RN 0.59.3

ERROR: Unable to resolve dependency for ':react-native-firebase@debug/compileClasspath': Could not resolve com.google.android.gms:play-services-basement:16.0.1.
Show Details
Affected Modules: react-native-firebase


ERROR: Unable to resolve dependency for ':react-native-firebase@debug/compileClasspath': Could not resolve com.google.android.gms:play-services-basement:16.2.0.
Show Details
Affected Modules: react-native-firebase


ERROR: Unable to resolve dependency for ':react-native-firebase@debug/compileClasspath': Could not resolve com.google.android.gms:play-services-basement:16.1.0.
Show Details
Affected Modules: react-native-firebase

e.g messed dependencies of play-services-basement 16.1.0 and 16.2.0

This is the complete list of my dependencies:

   implementation 'com.android.support:multidex:1.0.3'
   implementation("com.facebook.react:react-native:0.59.3")
   implementation project(':react-native-firebase')
   implementation 'com.google.firebase:firebase-core:16.0.8'
   implementation 'com.google.android.gms:play-services-base:16.1.0'
   implementation 'com.google.firebase:firebase-auth:16.2.0'
   implementation 'com.google.firebase:firebase-database:16.1.0'
   implementation 'com.google.firebase:firebase-firestore:18.2.0'

   compile (project(':react-native-device-info')) {
        transitive = true
   }

    implementation ('com.crashlytics.sdk.android:crashlytics:2.9.9') {
        transitive = true
    }

Here is the dependency tree:

+--- com.google.firebase:firebase-core:16.0.8
|    \--- com.google.firebase:firebase-analytics:16.4.0
|         +--- com.google.android.gms:play-services-measurement:16.4.0
|         |    +--- com.google.android.gms:play-services-basement:16.2.0
|         |    |    \--- com.android.support:support-v4:26.1.0 -> 28.0.0 (*)
|         |    +--- com.google.android.gms:play-services-measurement-base:[16.4.0] -> 16.4.0

+--- com.google.firebase:firebase-auth:16.2.0
|    +--- com.google.android.gms:play-services-base:16.0.1 -> 16.1.0 (*)
|    +--- com.google.android.gms:play-services-basement:16.1.0 -> 16.2.0 (*)

the strange thing here is that firebase-auth depends on 16.1.0 where the firebase-core depends on 16.2.0

Salakar added some commits Apr 8, 2019

@Salakar

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

@mgenov came across that myself as well today, have spent a few hours looking at this today frustratingly 😭 should be ok now though in rc3 if you could try that one - thanks

@invertase invertase deleted a comment from codecov bot Apr 8, 2019

@invertase invertase deleted a comment from codecov bot Apr 8, 2019

@mgenov

This comment has been minimized.

Copy link

commented Apr 8, 2019

Thanks @Salakar. The issue is resolved in rc3.

@mikehardy

This comment has been minimized.

Copy link
Collaborator

commented Apr 9, 2019

Some notes as I upgrade:

  • making the firestore date -> timestamp default to the breaking behavior seems like a request for punishment in the form of a lot of issues on github, but that's a possibly naive and/or possibly incorrect view 😃
  • there are already updates to the gradle deps for firebase-perf (16.2.5) and firebase-config (16.5.0) and firebase-messaging (17.6.0)

running on android and ios (after a pod update / pod install) but not using Firestore yet seems fine so far with no regressions on the packages I'm using the heaviest and have gone through so far (analytics + auth)

I'll be doing newbie firestore stuff tomorrow and will chime in if I see anything

Salakar added some commits Apr 9, 2019

@invertase invertase deleted a comment from codecov bot Apr 9, 2019

@invertase invertase deleted a comment from codecov bot Apr 9, 2019

@Salakar

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

@mikehardy

  • making the firestore date -> timestamp default to the breaking behavior seems like a request for punishment in the form of a lot of issues on github, but that's a possibly naive and/or possibly incorrect view 😃
  • there are already updates to the gradle deps for firebase-perf (16.2.5) and firebase-config (16.5.0) and firebase-messaging (17.6.0)
  1. I do feel the potential issue this could cause for people but also this is was introduced by the native SDKs and not something I did, there is a setting that can be changed in your app via firebase.firestore().settings({}) that can revert the behaviour but this is also deprecated - if someone upgrades their native sdks to versions not specified by this lib they'd be in for shock when it doesn't work at all - so thought best to do it now.

  2. Thanks for the heads-up, updated!

@Salakar

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

This has been published now to v5.3.0 on npm for the final release. Thanks for the feedback.

@Salakar Salakar merged commit 5e2d1bd into v5.x.x Apr 9, 2019

3 of 7 checks passed

ci/circleci: android-build-debug Your tests failed on CircleCI
Details
ci/circleci: android-build-release Your tests failed on CircleCI
Details
WIP work in progress
Details
ci/circleci: ios-test-e2e CircleCI is running your tests
Details
ci/circleci: analyse Your tests passed on CircleCI!
Details
ci/circleci: checkout-code Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Salakar Salakar deleted the @salakar/v5/v5.3.x branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.