feat(app): include play service utils #3240
Conversation
requestPermission example is missing `await` keyword.
Codecov Report
@@ Coverage Diff @@
## next #3240 +/- ##
==========================================
- Coverage 85.44% 85.07% -0.37%
==========================================
Files 108 108
Lines 3392 3407 +15
==========================================
Hits 2898 2898
- Misses 494 509 +15 |
packages/app/lib/utils/index.js
Outdated
| @@ -31,6 +31,41 @@ class FirebaseUtilsModule extends FirebaseModule { | |||
| return this.native.isRunningInTestLab; | |||
| } | |||
|
|
|||
| get androidPlayServices() { | |||
There was a problem hiding this comment.
This use to be called playServicesAvailability - the example above in the quick start also uses playServicesAvailability
There was a problem hiding this comment.
Thanks, Mike. Sorting out types now
Made a note on a couple small things I noticed, also the TS types are missing here
default `return` for iOS Co-Authored-By: Mike Diarmid <mike.diarmid@gmail.com>
Co-Authored-By: Mike Diarmid <mike.diarmid@gmail.com>
resolve promises Co-Authored-By: Mike Diarmid <mike.diarmid@gmail.com>
|
One to document in the new docs - maybe under app? |
|
@Ehesp Agreed. I've already put the |
| return Promise.resolve(null); | ||
| } | ||
| return this.native.androidGetPlayServicesStatus(); | ||
| } | ||
|
|
||
| promptForPlayServices() { | ||
| if (isIOS) { | ||
| return Promise.resolve(null); | ||
| } | ||
| return this.native.androidPromptForPlayServices(); | ||
| } | ||
|
|
||
| makePlayServicesAvailable() { | ||
| if (isIOS) { | ||
| return Promise.resolve(null); | ||
| } | ||
| return this.native.androidMakePlayServicesAvailable(); | ||
| } | ||
|
|
||
| resolutionForPlayServices() { | ||
| if (isIOS) { | ||
| return Promise.resolve(null); |
There was a problem hiding this comment.
Your types now say these return undefined on iOS; updated below to match;
| return Promise.resolve(null); | |
| } | |
| return this.native.androidGetPlayServicesStatus(); | |
| } | |
| promptForPlayServices() { | |
| if (isIOS) { | |
| return Promise.resolve(null); | |
| } | |
| return this.native.androidPromptForPlayServices(); | |
| } | |
| makePlayServicesAvailable() { | |
| if (isIOS) { | |
| return Promise.resolve(null); | |
| } | |
| return this.native.androidMakePlayServicesAvailable(); | |
| } | |
| resolutionForPlayServices() { | |
| if (isIOS) { | |
| return Promise.resolve(null); | |
| return Promise.resolve(); | |
| } | |
| return this.native.androidGetPlayServicesStatus(); | |
| } | |
| promptForPlayServices() { | |
| if (isIOS) { | |
| return Promise.resolve(); | |
| } | |
| return this.native.androidPromptForPlayServices(); | |
| } | |
| makePlayServicesAvailable() { | |
| if (isIOS) { | |
| return Promise.resolve(); | |
| } | |
| return this.native.androidMakePlayServicesAvailable(); | |
| } | |
| resolutionForPlayServices() { | |
| if (isIOS) { | |
| return Promise.resolve(); |
There was a problem hiding this comment.
I'm confused, I thought my types for iOS were returning null undefined I'll change accordingly
There was a problem hiding this comment.
Types only mention void (undefined), e.g. resolutionForPlayServices(): Promise<void>;:
If you change this then the @android docs tag on each probably also needs updating
There was a problem hiding this comment.
Ah, I see. Cool, I'll update to :Promise<void | null> for the types then
packages/app/lib/index.d.ts
Outdated
| * If true, allows the device to collect analytical data and send it to | ||
| * Firebase. Useful for GDPR. |
packages/app/lib/index.d.ts
Outdated
| @@ -379,6 +465,66 @@ export namespace Utils { | |||
| * @android | |||
| */ | |||
| isRunningInTestLab: boolean; | |||
|
|
|||
| /** | |||
| * Returns true if this app is running inside a Firebase Test Lab environment. Always returns false on iOS. | |||
fixes this issue: https://invertase.canny.io/react-native-firebase/p/playservicesavailability.
Summary
Checklist
AndroidiOSe2etests added or updated in packages/**/e2eTest Plan
Release Plan
[CATEGORY][type] [LOCATION] - Message
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter