From 36fe728a92dbb34e4fb851d070c3cebb5c8b7408 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simon=20W=C3=B6rpel?= <simon.woerpel@pm.me>
Date: Mon, 7 Aug 2023 15:10:35 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=92=A5=20load=5Fproxy=20->=20make=5Fproxy?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 ftmq/io.py          |  4 ++--
 tests/test_cli.py   | 10 +++++-----
 tests/test_io.py    |  7 +++----
 tests/test_proxy.py |  8 ++++----
 4 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/ftmq/io.py b/ftmq/io.py
index 0ed96e6..e4020b0 100644
--- a/ftmq/io.py
+++ b/ftmq/io.py
@@ -18,7 +18,7 @@
 log = logging.getLogger(__name__)
 
 
-def load_proxy(data: dict[str, Any], dataset: str | None = None) -> CE:
+def make_proxy(data: dict[str, Any], dataset: str | None = None) -> CE:
     datasets = ensure_list(data.pop("datasets", None))
     if dataset is not None:
         datasets.append(dataset)
@@ -89,7 +89,7 @@ def smart_read_proxies(
                 break
             data = orjson.loads(line)
             if serialize:
-                data = load_proxy(data)
+                data = make_proxy(data)
             yield data
 
 
diff --git a/tests/test_cli.py b/tests/test_cli.py
index 74358c1..6114281 100644
--- a/tests/test_cli.py
+++ b/tests/test_cli.py
@@ -5,7 +5,7 @@
 from nomenklatura.entity import CompositeEntity
 
 from ftmq.cli import cli
-from ftmq.io import load_proxy
+from ftmq.io import make_proxy
 
 runner = CliRunner()
 
@@ -24,7 +24,7 @@ def test_cli(fixtures_path: Path):
     assert result.exit_code == 0
     lines = _get_lines(result.output)
     assert len(lines) == 151
-    proxy = load_proxy(orjson.loads(lines[0]))
+    proxy = make_proxy(orjson.loads(lines[0]))
     assert isinstance(proxy, CompositeEntity)
 
     result = runner.invoke(cli, ["-i", in_uri, "-d", "other_dataset"])
@@ -65,7 +65,7 @@ def test_cli_apply(fixtures_path: Path):
     assert result.exit_code == 0
     lines = _get_lines(result.output)
     assert len(lines) == 151
-    proxy = load_proxy(orjson.loads(lines[0]))
+    proxy = make_proxy(orjson.loads(lines[0]))
     assert isinstance(proxy, CompositeEntity)
     assert "another_dataset" in proxy.datasets
     assert "eu_authorities" in proxy.datasets
@@ -78,7 +78,7 @@ def test_cli_apply(fixtures_path: Path):
     assert result.exit_code == 0
     lines = _get_lines(result.output)
     assert len(lines) == 151
-    proxy = load_proxy(orjson.loads(lines[0]))
+    proxy = make_proxy(orjson.loads(lines[0]))
     assert isinstance(proxy, CompositeEntity)
     assert "another_dataset" in proxy.datasets
     assert "eu_authorities" not in proxy.datasets
@@ -114,5 +114,5 @@ def test_cli_io(fixtures_path: Path):
     assert result.exit_code == 0
     lines = _get_lines(result.output)
     assert len(lines) == 151
-    proxy = load_proxy(orjson.loads(lines[0]))
+    proxy = make_proxy(orjson.loads(lines[0]))
     assert isinstance(proxy, CompositeEntity)
diff --git a/tests/test_io.py b/tests/test_io.py
index 352a96f..20ba57a 100644
--- a/tests/test_io.py
+++ b/tests/test_io.py
@@ -6,14 +6,13 @@
 
 from ftmq.io import (
     apply_datasets,
-    load_proxy,
+    make_proxy,
     smart_read,
     smart_read_proxies,
     smart_write,
     smart_write_proxies,
 )
-
-from .conftest import setup_s3
+from tests.conftest import setup_s3
 
 
 def test_io_read(fixtures_path: Path):
@@ -49,7 +48,7 @@ def test_io_write_stdout(capsys, proxies: list[CE]):
     captured = capsys.readouterr()
     proxy = None
     for line in captured.out.split("\n"):
-        proxy = load_proxy(orjson.loads(line))
+        proxy = make_proxy(orjson.loads(line))
         break
     assert isinstance(proxy, CompositeEntity)
 
diff --git a/tests/test_proxy.py b/tests/test_proxy.py
index 2825bae..2a2024e 100644
--- a/tests/test_proxy.py
+++ b/tests/test_proxy.py
@@ -2,13 +2,13 @@
 from followthemoney import model
 
 from ftmq.exceptions import ValidationError
-from ftmq.io import load_proxy
+from ftmq.io import make_proxy
 from ftmq.query import Query
 
 
 def test_proxy_composite():
     data = {"id": "1", "schema": "Thing", "properties": {"name": "Test"}}
-    proxy = load_proxy(data)
+    proxy = make_proxy(data)
     assert proxy.id == "1"
     assert proxy.get("name") == ["Test"]
     assert proxy.datasets == {"default"}
@@ -19,7 +19,7 @@ def test_proxy_composite():
         "properties": {"name": "Test"},
         "datasets": ["test_dataset"],
     }
-    proxy = load_proxy(data)
+    proxy = make_proxy(data)
     assert proxy.id == "1"
     assert proxy.get("name") == ["Test"]
     assert proxy.datasets == {"test_dataset"}
@@ -30,7 +30,7 @@ def test_proxy_composite():
         "properties": {"name": "Test"},
         "datasets": ["test_dataset", "ds2"],
     }
-    proxy = load_proxy(data, "another_dataset")
+    proxy = make_proxy(data, "another_dataset")
     assert proxy.id == "1"
     assert proxy.get("name") == ["Test"]
     assert proxy.datasets == {"another_dataset", "ds2", "test_dataset"}