Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better fix for Windows tsc build error, Can specify output dir from cLI #25

Merged
merged 2 commits into from Nov 10, 2017

Conversation

Projects
None yet
2 participants
@NQNStudios
Copy link
Collaborator

commented Nov 10, 2017

Addresses issue #21, #12

Changes proposed by this pull request:

  • Ignore every exit code of tsc except for 1
  • Remove examples/basic/index.html from the repo because it's a generated file
  • user can specify where to put the compiler's output (default dist)
  • build all examples into their own dist folders

@invicticide to review

@invicticide invicticide merged commit 4d1ed9f into invicticide:dev Nov 10, 2017

invicticide added a commit that referenced this pull request Nov 10, 2017

Merge PR #25 with my fix for unbundled scripts deployment
- Copy unbundled scripts to the output path
- Don't ignore examples/basic/dist/** as it's useful to check any diffs on the output as the compiler changes, as a kinda-sorta unit test

@NQNStudios NQNStudios deleted the NQNStudios:output-dir branch Nov 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.