Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettify option #30

Merged
merged 3 commits into from Nov 24, 2017

Conversation

Projects
None yet
2 participants
@NQNStudios
Copy link
Collaborator

commented Nov 24, 2017

Changes proposed by this pull request:

  • Instead of minification, the user can choose to prettify the output file.

@invicticide to review

@invicticide
Copy link
Owner

left a comment

This is a good change and is almost ready to accept.

The outputFormat option in the project schema should be declared as an enum with the valid values:

https://github.com/epoberezkin/ajv/blob/master/KEYWORDS.md#keywords-for-all-types

This obviates the need for the warning at Compiler.ts:146 as invalid values for outputFormat will be caught at validation time (at the top of Compiler.Compile()).

There also appears to be some spacing/bracket weirdness in the beautifier additions in Compiler.ts.

@invicticide invicticide merged commit c906fe5 into invicticide:dev Nov 24, 2017

@NQNStudios NQNStudios deleted the NQNStudios:prettify_option branch Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.