Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Addresses issue #9
Changes proposed by this pull request:
@invicticide to review
invicticide left a comment
I'm not sure the change in Compiler.RewriteLinkNode at 928, under the comment "For macro links, attributes become data attributes", is the cleanest way to handle this. Instead, I'd suggest we just take the
Separately, I think the
The motivation for tagging inline links is the same as the motivation for tagging external ones: neither link type navigates to a new section, which means that (for most cases) neither link type is a "meaningful" action in terms of game advancement; they're either "let's take a detour to this other website in parallel" or "let's get a little more information about this part of the current section".
Is the FontAwesome-enabled tag for
I like your logic because of all the times I've been playing a Twine game and wanted to make sure to click on all the inline links first. To take it another step further, we could also add an option to tag section links.
As for your last question, yup.
One more thing I'd like to change: I can imagine use-cases where it would be better to have a link tag prepended to the text instead. For example, if someone is making a JRPG action menu and the links are function links, it would look better to have the tag in front. I can implement a switch pretty quickly I think.