fix: Issue with calculating score on predictions with multiple genes - #5
Merged
Conversation
…es are potentially overwritten during iteration of the genes
sptaylor
approved these changes
Sep 19, 2023
bw2
added a commit
to bw2/Pangolin
that referenced
this pull request
Sep 26, 2023
… genes. Issue described @ invitae#5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue when there are multiple genes involved that the scores are potentially overwritten during iteration of the genes. Rather than modifying the scores for all genes during iteration, it is scoped to only modify information on the scores for each individual gene.