New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial test #21

Merged
merged 6 commits into from Jun 7, 2018

Conversation

Projects
None yet
2 participants
@duskybomb
Collaborator

duskybomb commented May 24, 2018

A PR to keep track of tests

  • _xml_from_file(): checking for pdf with and without embedded metadata.
    • for pdf without pdf check whether metadata has been added or not
    • what should I do for pdf with embedded data? Right now just checking whether returns None or not
  • write_pdf():
    • check for pdf in directory
    • check data has been embedded or not
  • write_xml(): should I parse it and compare?
@duskybomb

This comment has been minimized.

Show comment
Hide comment
@duskybomb

duskybomb May 24, 2018

Collaborator

I have been looking for how to compare two xml trees. I have found xmldiff.
Recommended by stackoverflow and some blog

Should I use it @m3nu?

Collaborator

duskybomb commented May 24, 2018

I have been looking for how to compare two xml trees. I have found xmldiff.
Recommended by stackoverflow and some blog

Should I use it @m3nu?

@m3nu

This comment has been minimized.

Show comment
Hide comment
@m3nu

m3nu May 25, 2018

Collaborator

xmldiff may be overkill since we are not interested in detailed differences, but in any difference. The latter is surely easier to implement.

Collaborator

m3nu commented May 25, 2018

xmldiff may be overkill since we are not interested in detailed differences, but in any difference. The latter is surely easier to implement.

@duskybomb

This comment has been minimized.

Show comment
Hide comment
@duskybomb

duskybomb May 28, 2018

Collaborator

Now this PR is ready for a review!

Collaborator

duskybomb commented May 28, 2018

Now this PR is ready for a review!

@duskybomb duskybomb changed the title from Initial test need to add more to Initial test Jun 2, 2018

Show outdated Hide outdated facturx/tests/test_facturx.py Outdated
Show outdated Hide outdated facturx/tests/test_facturx.py Outdated
@m3nu

This comment has been minimized.

Show comment
Hide comment
@m3nu

m3nu Jun 3, 2018

Collaborator

Still needs lots of work as well.

Collaborator

m3nu commented Jun 3, 2018

Still needs lots of work as well.

@m3nu m3nu closed this Jun 3, 2018

@m3nu m3nu reopened this Jun 3, 2018

duskybomb added some commits Jun 3, 2018

Changes after review:
 * Remove plagiarism
 * Remove setUp() instead use discover_file()
 * Use tostring() with 'remove_white_spce = True' to compare xml file
Show outdated Hide outdated facturx/tests/test_facturx.py Outdated
@m3nu

This comment has been minimized.

Show comment
Hide comment
@m3nu

m3nu Jun 7, 2018

Collaborator

I'll merge this as starting point for tests, but I'm not too happy with it.

Collaborator

m3nu commented Jun 7, 2018

I'll merge this as starting point for tests, but I'm not too happy with it.

@m3nu m3nu merged commit 8fe4067 into master Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment