New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save all fields to json? #114

Closed
msalaj opened this Issue May 9, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@msalaj

msalaj commented May 9, 2018

Hi, how it is possible to save all fields from template to json file? Currently, only date, amount and desc is written into output file. Program write complete json to screen but it writes only three fields to json file. Thank you

@m3nu

This comment has been minimized.

Show comment
Hide comment
@m3nu

m3nu May 10, 2018

Collaborator

Good idea. We didn't allow custom fields, when the json-export was implemented. Will mark this as new enhancement. Or you can do a PR, if in a hurry.

Collaborator

m3nu commented May 10, 2018

Good idea. We didn't allow custom fields, when the json-export was implemented. Will mark this as new enhancement. Or you can do a PR, if in a hurry.

@m3nu m3nu added this to the gsoc-1 milestone May 10, 2018

@duskybomb

This comment has been minimized.

Show comment
Hide comment
@duskybomb

duskybomb May 13, 2018

Collaborator

Won't it be more feasible to add this feature directly in GUI, where the user can choose as many as fields he wants to dump in json/csv/xml etc (was part of my proposal)?

Collaborator

duskybomb commented May 13, 2018

Won't it be more feasible to add this feature directly in GUI, where the user can choose as many as fields he wants to dump in json/csv/xml etc (was part of my proposal)?

@m3nu

This comment has been minimized.

Show comment
Hide comment
@m3nu

m3nu May 14, 2018

Collaborator

No. Unit testing means that a single functional unit is tested. So testing extraction and templates at the library level is the right thing to do. The GUI relies on this functional units and adds on them.

Collaborator

m3nu commented May 14, 2018

No. Unit testing means that a single functional unit is tested. So testing extraction and templates at the library level is the right thing to do. The GUI relies on this functional units and adds on them.

@duskybomb

This comment has been minimized.

Show comment
Hide comment
@duskybomb

duskybomb May 14, 2018

Collaborator

There are two ways to implement this

  • Adding it to template where author specifies fields he wants to dump (I am not in favour of this)
  • Using cli, with an option to dump default fields or all the fields.
Collaborator

duskybomb commented May 14, 2018

There are two ways to implement this

  • Adding it to template where author specifies fields he wants to dump (I am not in favour of this)
  • Using cli, with an option to dump default fields or all the fields.
@m3nu

This comment has been minimized.

Show comment
Hide comment
@m3nu

m3nu May 14, 2018

Collaborator

Let's always dump all fields. No need to specify or make a template.

Collaborator

m3nu commented May 14, 2018

Let's always dump all fields. No need to specify or make a template.

@duskybomb

This comment has been minimized.

Show comment
Hide comment
@duskybomb

duskybomb May 14, 2018

Collaborator

Closing this one.

Collaborator

duskybomb commented May 14, 2018

Closing this one.

@duskybomb duskybomb closed this May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment