fix clipseg loading problems #1177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The directory "models" in the main InvokeAI directory was conflicting with loading "models.clipseg". To fix this issue, I have renamed the models.clipseg to clipseg_models.clipseg, and applied this change to the 'models-rename' branch of invoke-ai's fork of clipseg.
- The directory "models" in the main InvokeAI directory was conflicting with loading "models.clipseg". To fix this issue, I have renamed the models.clipseg to clipseg_models.clipseg, and applied this change to the 'models-rename' branch of invoke-ai's fork of clipseg.
Collaborator
Author
|
This ought to fix #1150 |
Contributor
|
Followed instructions to re-do the clipseg installation, it works. I did need to run Also, there were issues with the |
- The !mask command takes an image path, a text prompt, and (optionally) a masking threshold. It creates a mask over the region indicated by the prompt, and outputs several files that show which regions will be masked by the chosen prompt and threshold. - The mask images should not be passed directly to img2img because they are designed for visualization only. Instead, use the --text_mask option to pass the selected prompt and threshold. - See docs/features/INPAINTING.md for details.
psychedelicious
approved these changes
Oct 20, 2022
Contributor
psychedelicious
left a comment
psychedelicious
left a comment
There was a problem hiding this comment.
- Tested out the
!maskcommand - works great. The threshold does what it should as well. - Feature also works as expected when used with img2img
- I deleted my
src/clipseg/weightsdir and re-ranpreload_models.py, it re-loaded the models successfully
Awesome feature!
Collaborator
Author
|
I'm going to take this as a "approve" and force merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The directory "models" in the main InvokeAI directory was conflicting with loading "models.clipseg". To fix this issue, I have renamed the models.clipseg to clipseg_models.clipseg, and applied this change to the 'models-rename' branch of invoke-ai's fork of clipseg.
After pulling this PR, please delete
src/clipsegand rerunconda env updateUPDATE: I have also folded in the !mask command to visualize the regions found by
clipseg. See docs/features/INPAINTING.md for the details.