Skip to content

Conversation

@lstein
Copy link
Collaborator

@lstein lstein commented Mar 25, 2023

This includes a number of bug fixes described in the draft release notes.

It also incorporates a modified version of the dialog-based invoke.sh script suggested by JoshuaKimsey:
https://discord.com/channels/1020123559063990373/1089119602425995304

Incorporates a modified version of the dialog-based invoke.sh script
suggested by JoshuaKimsey:
https://discord.com/channels/1020123559063990373/1089119602425995304
@lstein lstein requested a review from ebr as a code owner March 25, 2023 21:01
@lstein lstein requested a review from blessedcoolant March 25, 2023 21:01
- Imported V2 legacy models will now autoconvert into diffusers
  at load time regardless of setting of --ckpt_convert.

- model manager `heuristic_import()` function now looks for
  side-by-side yaml and vae files for custom configuration and VAE
  respectively.

Example of this:

  illuminati-v1.1.safetensors
  illuminati-v1.1.vae.safetensors
  illuminati-v1.1.yaml

When the user tries to import `illuminati-v1.1.safetensors`, the yaml
file will be used for its configuration, and the VAE will be used for
its VAE. Conversion to diffusers will happen if needed, and the yaml
file will be used to determine which V2 format (if any) to apply.
- Imported V2 legacy models will now autoconvert into diffusers at load
time regardless of setting of --ckpt_convert.

- model manager `heuristic_import()` function now looks for side-by-side
yaml and vae files for custom configuration and VAE respectively.

Example of this:

illuminati-v1.1.safetensors illuminati-v1.1.vae.safetensors
illuminati-v1.1.yaml

When the user tries to import `illuminati-v1.1.safetensors`, the yaml
file will be used for its configuration, and the VAE will be used for
its VAE. Conversion to diffusers will happen if needed, and the yaml
file will be used to determine which V2 format (if any) to apply.

NOTE that the changes to `ckpt_to_diffusers.py` were previously reviewed
by @JPPhoto on the `main` branch and approved.
@lstein lstein requested a review from mauwii as a code owner March 26, 2023 15:49
Copy link
Contributor

@ebr ebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interactive invoke.sh dialog is really wonderful, though I did have to install the dialog utility to make it work (Pop!OS 22.04).

I think at some point we're going to have to rethink these options. The 10-item list is getting overwhelming for the user, and having to maintain it in two places is not ideal. Also it's not necessarily clear that options 5, 6 and 7 have subtle redundancies. But that aside, the textual UX is great.

Approving w/ a grammatical correction

Co-authored-by: Eugene Brodsky <ebr@users.noreply.github.com>
@lstein
Copy link
Collaborator Author

lstein commented Mar 27, 2023

The interactive invoke.sh dialog is really wonderful, though I did have to install the dialog utility to make it work (Pop!OS 22.04).

I think at some point we're going to have to rethink these options. The 10-item list is getting overwhelming for the user, and having to maintain it in two places is not ideal. Also it's not necessarily clear that options 5, 6 and 7 have subtle redundancies. But that aside, the textual UX is great.

Approving w/ a grammatical correction

In fact this exposes a basic problem with how we do the updates. The updater updates python libraries and the configuration files but not other things inside the invokeai directory such as the launcher scripts. Ideally the launcher script should just be a four-line frontend that changes to the root directory, activates the environment, sets up any environment variables needed, and then calls a python module to do the interactive menu.

@ebr, how's your bandwidth these days? Any interest in refactoring the menu choices?

@lstein lstein merged commit 77a63e5 into v2.3 Mar 27, 2023
@lstein lstein deleted the release/v2.3.3-rc1 branch March 27, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants