-
Notifications
You must be signed in to change notification settings - Fork 2.7k
this is release candidate 2.3.3-rc1 #3033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Incorporates a modified version of the dialog-based invoke.sh script suggested by JoshuaKimsey: https://discord.com/channels/1020123559063990373/1089119602425995304
- Imported V2 legacy models will now autoconvert into diffusers at load time regardless of setting of --ckpt_convert. - model manager `heuristic_import()` function now looks for side-by-side yaml and vae files for custom configuration and VAE respectively. Example of this: illuminati-v1.1.safetensors illuminati-v1.1.vae.safetensors illuminati-v1.1.yaml When the user tries to import `illuminati-v1.1.safetensors`, the yaml file will be used for its configuration, and the VAE will be used for its VAE. Conversion to diffusers will happen if needed, and the yaml file will be used to determine which V2 format (if any) to apply.
- Imported V2 legacy models will now autoconvert into diffusers at load time regardless of setting of --ckpt_convert. - model manager `heuristic_import()` function now looks for side-by-side yaml and vae files for custom configuration and VAE respectively. Example of this: illuminati-v1.1.safetensors illuminati-v1.1.vae.safetensors illuminati-v1.1.yaml When the user tries to import `illuminati-v1.1.safetensors`, the yaml file will be used for its configuration, and the VAE will be used for its VAE. Conversion to diffusers will happen if needed, and the yaml file will be used to determine which V2 format (if any) to apply. NOTE that the changes to `ckpt_to_diffusers.py` were previously reviewed by @JPPhoto on the `main` branch and approved.
ebr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interactive invoke.sh dialog is really wonderful, though I did have to install the dialog utility to make it work (Pop!OS 22.04).
I think at some point we're going to have to rethink these options. The 10-item list is getting overwhelming for the user, and having to maintain it in two places is not ideal. Also it's not necessarily clear that options 5, 6 and 7 have subtle redundancies. But that aside, the textual UX is great.
Approving w/ a grammatical correction
Co-authored-by: Eugene Brodsky <ebr@users.noreply.github.com>
In fact this exposes a basic problem with how we do the updates. The updater updates python libraries and the configuration files but not other things inside the invokeai directory such as the launcher scripts. Ideally the launcher script should just be a four-line frontend that changes to the root directory, activates the environment, sets up any environment variables needed, and then calls a python module to do the interactive menu. @ebr, how's your bandwidth these days? Any interest in refactoring the menu choices? |
This includes a number of bug fixes described in the draft release notes.
It also incorporates a modified version of the dialog-based invoke.sh script suggested by JoshuaKimsey:
https://discord.com/channels/1020123559063990373/1089119602425995304