feat: increase seed from int32 to uint32 #3933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point I typo'd this and set the max seed to signed int32 max. It should be *un*signed int32 max. This restored the seed range to what it was in v2.3.
This was incorect and resulted in the max seed being one less than intended.
psychedelicious
requested review from
Kyle0654,
blessedcoolant,
brandonrising and
maryhipp
as code owners
blessedcoolant
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
At some point I typo'd this and set the max seed to signed int32 max. It should be unsigned int32 max.
This restored the seed range to what it was in v2.3.
Also fixed a bug in the Noise node which resulted in the max valid seed being one less than intended.
Related Tickets & Documents
increase random number seed space #2843 is against v2.3 and increases the range of valid seeds substantially. Maybe we can explore this in the future but as of v3.0, we use numpy for a RNG in a few places, and it maxes out at the max
uint32. I will close this PR as this supersedes it.QA Instructions, Screenshots, Recordings
You should be able to use seeds up to and including
4294967295.Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
nope!