Skip to content

Conversation

@ymgenesis
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Have you updated all relevant documentation?

  • Yes
  • No

Description

Updated broken image links in NODES.md

@Millu
Copy link
Contributor

Millu commented Jul 25, 2023

Thanks for updating these!

For the future, you can link images in the docs with the relative path like this: ![image](assests/sub_folder/screenshot.png) (assuming the images have been added to the assets/sub_folder folder)

@ymgenesis
Copy link
Contributor Author

@Millu Sure! I had them in assets before it was committed to invoke's main, and for some reason they disappeared. I had just uploaded them when editing directly in my fork and branch.

lstein
lstein previously requested changes Jul 25, 2023
Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a great idea for us to rely on a third party image-serving service for this. Could you move the images into the repo under ./docs/assets/nodes/ and refer to them using markdown following this format:

![groupsnoise](../assets/nodes/groupsnoise.png"){width=654px }

It looks like the original author of NODES.md didn't realize that the docs would be passed through mkdocs before publication, and I didn't notice all the broken image icons till just now.

@ymgenesis
Copy link
Contributor Author

@lstein Done. I had written the documentation originally, and wasn't aware of the process the assets would go through after being committed. Should be all good now!

@hipsterusername hipsterusername force-pushed the docs/features/NODES.md---Fix-image-links branch from 1f67622 to d682ee8 Compare July 26, 2023 00:27
Copy link
Member

@hipsterusername hipsterusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@hipsterusername hipsterusername force-pushed the docs/features/NODES.md---Fix-image-links branch from d682ee8 to b06d53f Compare July 26, 2023 01:48
@hipsterusername hipsterusername merged commit d5998ad into invoke-ai:main Jul 26, 2023
@ymgenesis ymgenesis deleted the docs/features/NODES.md---Fix-image-links branch July 27, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants