fix(backend): handle systems with glibc < 2.33
#4879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
GreggHelt2,
StAlKeR7779,
blessedcoolant,
brandonrising,
damian0815,
hipsterusername and
lstein
as code owners
RyanJDick
approved these changes
Oct 14, 2023
Contributor
RyanJDick
left a comment
RyanJDick
left a comment
There was a problem hiding this comment.
Thanks for jumping on this. Looks good to me!
`mallinfo2` is not available on `glibc` < 2.33. On these systems, we successfully load the library but get an `AttributeError` on attempting to access `mallinfo2`. I'm not sure if the old `mallinfo` will work, and not sure how to install it safely to test, so for now we just handle the `AttributeError`. This means the enhanced memory snapshot logic will be skipped for these systems, which isn't a big deal.
hipsterusername
force-pushed
the
fix/backend/mallinfo-old-glibc
branch
from
6d28a89 to
f19c606
Compare
hipsterusername
approved these changes
Oct 14, 2023
lstein
pushed a commit
that referenced
this pull request
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
fix(backend): handle systems with glibc < 2.33
mallinfo2is not available onglibc< 2.33.On these systems, we successfully load the library but get an
AttributeErroron attempting to accessmallinfo2.I'm not sure if the old
mallinfowill work, and not sure how to install it safely to test, so for now we just handle theAttributeError.This means the enhanced memory snapshot logic will be skipped for these systems, which isn't a big deal.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
@RyanJDick Requesting your review for this.
@RaphaelDreams , ideally you could test this PR on your affected system to confirm it resolves the issue. From my read of the code, it will, but I'm not sure how to test the fix on my system.
Added/updated tests?
have not been included