-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: openapi stuff #6454
Merged
Merged
fix: openapi stuff #6454
Commits on May 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e257a72 - Browse repository at this point
Copy the full SHA e257a72View commit details -
fix(app): openapi schema generation
Some tech debt related to dynamic pydantic schemas for invocations became problematic. Including the invocations and results in the event schemas was breaking pydantic's handling of ref schemas. I don't really understand why - I think it's a pydantic bug in a remote edge case that we are hitting. After many failed attempts I landed on this implementation, which is actually much tidier than what was in there before. - Create pydantic-enabled types for `AnyInvocation` and `AnyInvocationOutput` and use these in place of the janky dynamic unions. Actually, they are kinda the same, but better encapsulated. Use these in `Graph`, `GraphExecutionState`, `InvocationEventBase` and `InvocationCompleteEvent`. - Revise the custom openapi function to work with the new models. - Split out the custom openapi function to a separate file. Add a `post_transform` callback so consumers can customize the output schema. - Update makefile scripts.
Configuration menu - View commit details
-
Copy full SHA for 2f9ebde - Browse repository at this point
Copy the full SHA 2f9ebdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7590f30 - Browse repository at this point
Copy the full SHA 7590f30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a4d104 - Browse repository at this point
Copy the full SHA 5a4d104View commit details -
feat(api): sort openapi schemas
Reduces the constant changes to the frontend client types due to inconsistent ordering of pydantic models.
Configuration menu - View commit details
-
Copy full SHA for 5beec82 - Browse repository at this point
Copy the full SHA 5beec82View commit details -
feat(app): dynamic type adapters for invocations & outputs
Keep track of whether or not the typeadapter needs to be updated. Allows for dynamic invocation and output unions.
Configuration menu - View commit details
-
Copy full SHA for 50d3030 - Browse repository at this point
Copy the full SHA 50d3030View commit details -
fix(app): add dynamic validator to AnyInvocation & AnyInvocationOutput
This fixes the tests and slightly changes output types.
Configuration menu - View commit details
-
Copy full SHA for ac56ab7 - Browse repository at this point
Copy the full SHA ac56ab7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cb32d3 - Browse repository at this point
Copy the full SHA 7cb32d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a983f27 - Browse repository at this point
Copy the full SHA a983f27View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.