Fix around 30 memory leaks #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The parts where i changed the |
|
Thank you very much, I'll try to spend some time to extend unit testing |
|
Could you please upload a new release to CPAN with these changes? We have production machines that need the patch, and applying it manually is not very nice. |
SPodjasek
added a commit
that referenced
this pull request
May 23, 2019
Changelog diff is:
diff --git a/Changes b/Changes
index 29c44d8..75daeef 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,8 @@
{{$NEXT}}
+0.2.2 2019-05-23T11:20:22Z
+ - Minor documentation fixes #32 (@sjn)
+ - fix around 30 memory leaks #31 (@kraih)
0.2.1 2018-07-29T14:17:43Z
- Fixed POD syntax, spelling & grammar errors #27,#28 (@gregoa)
- Fixed POD error #26 (@manwar)
|
Done |
SPodjasek
added a commit
that referenced
this pull request
Jul 24, 2019
Changelog diff is:
diff --git a/Changes b/Changes
index 75daeef..eadeda1 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,7 @@
{{$NEXT}}
+0.2.3 2019-07-24T21:06:16Z
+ - Clarified documentation #33, #34 (@AdamWill)
0.2.2 2019-05-23T11:20:22Z
- Minor documentation fixes #32 (@sjn)
- fix around 30 memory leaks #31 (@kraih)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix all the memory leaks i mentioned in #30. The way promises are used to wrap an event emitter API is really unfortunate, since it makes creating leaks very very easy. The two scripts i've used to test for leaks are here and here. So i should have most of the publisher and channel APIs covered.