Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file system's default for builder default - p4 #21

Closed
DaveJarvis opened this issue Apr 9, 2021 · 1 comment
Closed

Use file system's default for builder default - p4 #21

DaveJarvis opened this issue Apr 9, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@DaveJarvis
Copy link
Collaborator

DaveJarvis commented Apr 9, 2021

Code that opens a file chooser and select at most one file, minimally is documented as:

final var configuration =
  JWFileChooserConfiguration.builder()
    .setFileSystem(FileSystems.getDefault())
    .build();

Consider making FileSystems.getDefault() the default configuration setting, which changes the minimum to:

final var configuration =
  JWFileChooserConfiguration.builder().build();
@DaveJarvis DaveJarvis changed the title Use file system's default for builder default Use file system's default for builder default - p4 Apr 9, 2021
@io7m
Copy link
Owner

io7m commented Apr 9, 2021

Seems OK. Keep in mind that the specified filesystem has to be the same filesystem used in all Path values in the configuration.

@DaveJarvis DaveJarvis added the enhancement New feature or request label Apr 11, 2021
@io7m io7m closed this as completed in f1631d1 May 1, 2021
io7m added a commit that referenced this issue May 18, 2021
Release: com.io7m.jwheatsheaf 3.0.0

A big thanks to @DaveJarvis for suggestions, bug reports, and some
code contributions!

Change: Add the ability to specify custom strings (Ticket: #7)
Change: Add the ability to confirm file selections (Ticket: #17)
Change: Allow for including ".." in directory listings (Ticket: #23)
Change: Improve "select directly" dialog behaviour (Ticket: #29)
Change: Fix the size formatter (Ticket: #30)
Change: Use the default filesystem by default (Ticket: #21)
Change: Add support for glob-based filters (Ticket: #19)
Change: Improve filename field behaviour (Ticket: #28)
Change: Add an optional home directory button (Ticket: #12)
Change: Enable sorting of directory items (Ticket: #22)
Change: Allow for setting a default file filter (Ticket: #9)
Change: Allow the escape key to close file choosers (Ticket: #14)
Change: Allow for specifying an initial filename in choosers (Ticket: #15)
Change: Allow for specifying custom dialog titles (Ticket: #8)
Change: Make the default filters part of the public API (Ticket: #10)
io7m added a commit that referenced this issue May 18, 2021
Release: com.io7m.jwheatsheaf 3.0.0

A big thanks to @DaveJarvis for suggestions, bug reports, and some
code contributions!

Change: Add the ability to specify custom strings (Ticket: #7)
Change: Add the ability to confirm file selections (Ticket: #17)
Change: Allow for including ".." in directory listings (Ticket: #23)
Change: Improve "select directly" dialog behaviour (Ticket: #29)
Change: Fix the size formatter (Ticket: #30)
Change: Use the default filesystem by default (Ticket: #21)
Change: Add support for glob-based filters (Ticket: #19)
Change: Improve filename field behaviour (Ticket: #28)
Change: Add an optional home directory button (Ticket: #12)
Change: Enable sorting of directory items (Ticket: #22)
Change: Allow for setting a default file filter (Ticket: #9)
Change: Allow the escape key to close file choosers (Ticket: #14)
Change: Allow for specifying an initial filename in choosers (Ticket: #15)
Change: Allow for specifying custom dialog titles (Ticket: #8)
Change: Make the default filters part of the public API (Ticket: #10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants