Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow traversal to path when entered - p2 #29

Closed
DaveJarvis opened this issue Apr 12, 2021 · 1 comment
Closed

Allow traversal to path when entered - p2 #29

DaveJarvis opened this issue Apr 12, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@DaveJarvis
Copy link
Collaborator

DaveJarvis commented Apr 12, 2021

When pasting a path into the input field, the File chooser navigates to the leaf's parent directory, rather than the leaf directory.

  1. Open File chooser
  2. Click button to enter full path directly
  3. Paste a complete path to an existing directory (e.g., /home/username/dev/java/keenwrite/docs)
  4. Press Enter

Expected: List of all files inside docs directory appears.

Actual: List of all files inside keenwrite directory appears.

Work around

Append /. to the path to ensure navigation is successful.

Relates to #13

@DaveJarvis DaveJarvis added the bug Something isn't working label Apr 12, 2021
@DaveJarvis DaveJarvis changed the title Allow traversal to path when entered Allow traversal to path when entered - p2 Apr 12, 2021
@io7m
Copy link
Owner

io7m commented May 1, 2021

Nice catch!

@io7m io7m closed this as completed in 1ea9115 May 1, 2021
io7m added a commit that referenced this issue May 18, 2021
Release: com.io7m.jwheatsheaf 3.0.0

A big thanks to @DaveJarvis for suggestions, bug reports, and some
code contributions!

Change: Add the ability to specify custom strings (Ticket: #7)
Change: Add the ability to confirm file selections (Ticket: #17)
Change: Allow for including ".." in directory listings (Ticket: #23)
Change: Improve "select directly" dialog behaviour (Ticket: #29)
Change: Fix the size formatter (Ticket: #30)
Change: Use the default filesystem by default (Ticket: #21)
Change: Add support for glob-based filters (Ticket: #19)
Change: Improve filename field behaviour (Ticket: #28)
Change: Add an optional home directory button (Ticket: #12)
Change: Enable sorting of directory items (Ticket: #22)
Change: Allow for setting a default file filter (Ticket: #9)
Change: Allow the escape key to close file choosers (Ticket: #14)
Change: Allow for specifying an initial filename in choosers (Ticket: #15)
Change: Allow for specifying custom dialog titles (Ticket: #8)
Change: Make the default filters part of the public API (Ticket: #10)
io7m added a commit that referenced this issue May 18, 2021
Release: com.io7m.jwheatsheaf 3.0.0

A big thanks to @DaveJarvis for suggestions, bug reports, and some
code contributions!

Change: Add the ability to specify custom strings (Ticket: #7)
Change: Add the ability to confirm file selections (Ticket: #17)
Change: Allow for including ".." in directory listings (Ticket: #23)
Change: Improve "select directly" dialog behaviour (Ticket: #29)
Change: Fix the size formatter (Ticket: #30)
Change: Use the default filesystem by default (Ticket: #21)
Change: Add support for glob-based filters (Ticket: #19)
Change: Improve filename field behaviour (Ticket: #28)
Change: Add an optional home directory button (Ticket: #12)
Change: Enable sorting of directory items (Ticket: #22)
Change: Allow for setting a default file filter (Ticket: #9)
Change: Allow the escape key to close file choosers (Ticket: #14)
Change: Allow for specifying an initial filename in choosers (Ticket: #15)
Change: Allow for specifying custom dialog titles (Ticket: #8)
Change: Make the default filters part of the public API (Ticket: #10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants