New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata-add and metadata-remove commands #20

Closed
io7m opened this Issue Dec 29, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@io7m
Owner

io7m commented Dec 29, 2016

This allows for adding and removing metadata during filtering.

@io7m io7m added the enhancement label Dec 29, 2016

@io7m io7m self-assigned this Dec 29, 2016

@io7m io7m added this to the 0.4.0 milestone Dec 29, 2016

@io7m

This comment has been minimized.

Show comment
Hide comment
@io7m

io7m Dec 29, 2016

Owner

This needs more consideration, because the commands can only be on a single line. It might be necessary for the metadata-add command to take a filename as an argument.

Owner

io7m commented Dec 29, 2016

This needs more consideration, because the commands can only be on a single line. It might be necessary for the metadata-add command to take a filename as an argument.

@io7m

This comment has been minimized.

Show comment
Hide comment
@io7m

io7m Dec 29, 2016

Owner

Moving this beyond 0.4.0. There are security concerns with allowing filters to open files and so on.

Owner

io7m commented Dec 29, 2016

Moving this beyond 0.4.0. There are security concerns with allowing filters to open files and so on.

@io7m io7m modified the milestones: 0.4.0, 0.5.0 Dec 29, 2016

io7m added a commit that referenced this issue Jan 10, 2017

Add path resolution API for filters
This allows for filters to restrict file inclusions to within the
source directory.

Affects #20

@io7m io7m added this to the 0.7.0 milestone Jan 23, 2017

@io7m

This comment has been minimized.

Show comment
Hide comment
@io7m

io7m Jan 23, 2017

Owner

The infrastructure is in place to provide this safely now.

Owner

io7m commented Jan 23, 2017

The infrastructure is in place to provide this safely now.

@io7m io7m closed this in 076b9bd Jan 23, 2017

io7m added a commit that referenced this issue Jan 23, 2017

Merge branch 'release/0.7.0'
Release: io7m-smfj 0.7.0
Code fix: Use jcoords 0.1.3 to fix OSGi.
Code new: Add metadata-add and metadata-remove commands. (tickets: #20, #34)
Code new: Add OSGi annotations. (tickets: #33)
Code new: Add ByteBuffer packed meshes.
Code change: SMFParserEventsMetaType no longer extends SMFParserEventsErrorType.
Code new: Add SMFParseErrorType#fullMessage()
Code new: Add validation API
Code new: Add a schema language for the validation API

io7m added a commit that referenced this issue Jan 23, 2017

Merge tag 'io7m-smf-0.7.0' into develop
Release: io7m-smfj 0.7.0

Code fix: Use jcoords 0.1.3 to fix OSGi.
Code new: Add metadata-add and metadata-remove commands. (tickets: #20, #34)
Code new: Add OSGi annotations. (tickets: #33)
Code new: Add ByteBuffer packed meshes.
Code change: SMFParserEventsMetaType no longer extends SMFParserEventsErrorType.
Code new: Add SMFParseErrorType#fullMessage()
Code new: Add validation API
Code new: Add a schema language for the validation API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment