New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializer state transition bug #34

Closed
io7m opened this Issue Jan 23, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@io7m
Owner

io7m commented Jan 23, 2017

Serializing metadata fails for both the text and binary formats:

smf: Main: ERROR: Cannot transition between the given states.
  Current state:   STATE_DATA_METADATA_FINISHED
  Requested state: STATE_DATA_METADATA_IN_PROGRESS

com.io7m.jfsm.core.FSMTransitionException: Cannot transition between the given states.
  Current state:   STATE_DATA_METADATA_FINISHED
  Requested state: STATE_DATA_METADATA_IN_PROGRESS

	at com.io7m.jfsm.core.FSMEnumMutable.transition(FSMEnumMutable.java:99)
	at com.io7m.smfj.format.text.SMFTV1Serializer.serializeMetadata(SMFTV1Serializer.java:705)
	at com.io7m.smfj.processing.api.SMFMemoryMeshSerializer.serialize(SMFMemoryMeshSerializer.java:94)
	at com.io7m.smfj.cmdline.Main$CommandFilter.call(Main.java:407)
	at com.io7m.smfj.cmdline.Main$CommandFilter.call(Main.java:294)
	at com.io7m.smfj.cmdline.Main.run(Main.java:142)
	at com.io7m.smfj.cmdline.Main.main(Main.java:114)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)

Why have the unit tests not detected this error?

@io7m io7m added the bug label Jan 23, 2017

@io7m io7m added this to the 0.7.0 milestone Jan 23, 2017

@io7m io7m self-assigned this Jan 23, 2017

@io7m

This comment has been minimized.

Show comment
Hide comment
@io7m

io7m Jan 23, 2017

Owner

This actually turned out to be a bug in a not-yet-committed filter command. In order to prevent any occurrences of this happening in the future, new preconditions were added to the memory mesh type.

Owner

io7m commented Jan 23, 2017

This actually turned out to be a bug in a not-yet-committed filter command. In order to prevent any occurrences of this happening in the future, new preconditions were added to the memory mesh type.

@io7m io7m closed this in 076b9bd Jan 23, 2017

io7m added a commit that referenced this issue Jan 23, 2017

Merge branch 'release/0.7.0'
Release: io7m-smfj 0.7.0
Code fix: Use jcoords 0.1.3 to fix OSGi.
Code new: Add metadata-add and metadata-remove commands. (tickets: #20, #34)
Code new: Add OSGi annotations. (tickets: #33)
Code new: Add ByteBuffer packed meshes.
Code change: SMFParserEventsMetaType no longer extends SMFParserEventsErrorType.
Code new: Add SMFParseErrorType#fullMessage()
Code new: Add validation API
Code new: Add a schema language for the validation API

io7m added a commit that referenced this issue Jan 23, 2017

Merge tag 'io7m-smf-0.7.0' into develop
Release: io7m-smfj 0.7.0

Code fix: Use jcoords 0.1.3 to fix OSGi.
Code new: Add metadata-add and metadata-remove commands. (tickets: #20, #34)
Code new: Add OSGi annotations. (tickets: #33)
Code new: Add ByteBuffer packed meshes.
Code change: SMFParserEventsMetaType no longer extends SMFParserEventsErrorType.
Code new: Add SMFParseErrorType#fullMessage()
Code new: Add validation API
Code new: Add a schema language for the validation API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment