New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the byte buffer packing API to return errors #37

Closed
io7m opened this Issue Jan 24, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@io7m
Owner

io7m commented Jan 24, 2017

Right now, there's this:

SortedMap<Integer, SMFByteBufferPackingConfiguration> onHeader(SMFHeader header);

The API should be designed such that validation is expected to occur inside this function. As such, it needs to be declared so that returning a list of errors is allowed.

@io7m io7m added the enhancement label Jan 24, 2017

@io7m io7m self-assigned this Jan 24, 2017

@io7m io7m added this to the 0.8.0 milestone Jan 24, 2017

@io7m io7m closed this in 95f8f43 Jan 24, 2017

io7m added a commit that referenced this issue Jan 27, 2017

Merge branch 'release/0.8.0'
Release: io7m-smfj 0.8.0
Code change: Change bytebuffer API to allow failures; introduce a codebase-wide general error type. (tickets: #37)
Code fix: Correct triangle size calculation for ByteBuffer cursors. (tickets: #38)
Code change: Abstract header triangle information into its own SMFTriangles type.
Code change: The byte buffer event method onAllocateTriangleBuffer() now takes an SMFTriangles value.

io7m added a commit that referenced this issue Jan 27, 2017

Merge tag 'io7m-smf-0.8.0' into develop
Release: io7m-smfj 0.8.0

Code change: Change bytebuffer API to allow failures; introduce a codebase-wide general error type. (tickets: #37)
Code fix: Correct triangle size calculation for ByteBuffer cursors. (tickets: #38)
Code change: Abstract header triangle information into its own SMFTriangles type.
Code change: The byte buffer event method onAllocateTriangleBuffer() now takes an SMFTriangles value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment