Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zigbee2mqtt #1976

Merged
merged 8 commits into from
Jan 13, 2023
Merged

Add zigbee2mqtt #1976

merged 8 commits into from
Jan 13, 2023

Conversation

o0shojo0o
Copy link
Contributor

No description provided.

@GermanBluefox GermanBluefox added the auto-checked This PR was automatically checked for obvious criterias label Oct 14, 2022
@GermanBluefox
Copy link
Contributor

Automated adapter checker

ioBroker.zigbee2mqtt

Downloads Number of Installations (latest)
NPM

👍 No errors found

  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
  • 👀 [W400] Cannot find "zigbee2mqtt" in latest repository

Add comment "RE-CHECK!" to start check anew

@Apollon77
Copy link
Collaborator

Hi,
hhere a short review feedback:

Rest I only fly over and looked ok ... Please check and adjust the above

@Apollon77 Apollon77 added question Something needs to be done or answered by the adapter developer must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review and removed auto-checked This PR was automatically checked for obvious criterias labels Nov 16, 2022
o0shojo0o added a commit to arteck/ioBroker.zigbee2mqtt that referenced this pull request Nov 16, 2022
@o0shojo0o
Copy link
Contributor Author

Thank you for your review, I have fixed all the points.

@o0shojo0o
Copy link
Contributor Author

@Apollon77 are there still open points?

@Apollon77
Copy link
Collaborator

Yes me finding time for recheck.

@o0shojo0o
Copy link
Contributor Author

Add to stable @2.5.0

@o0shojo0o
Copy link
Contributor Author

Update stable to v2.6.0

@Apollon77
Copy link
Collaborator

Sorry that the re-review too that long ... elcome in the repo!

One "note/tip" for unload: Alw<ys do the stuff first that should not throw any exception (like ending timers and intervals) and do other afterwards (or in separate try/catches) because as soon as one gives exception the rest of the code in the try/catch block is not executed. But thats optimization

@Apollon77
Copy link
Collaborator

oooooohhhhh @o0shojo0o one thing ... type "lighting"??? I think it is more or? type "hardware" like ziugbee adapter?

A change here would be "io.package change on github" and the PR here ... Can you please do that before I merge?
A new release is not urgently needed ... enough for next update

@o0shojo0o
Copy link
Contributor Author

fixed ;)

@Apollon77 Apollon77 merged commit 93412b3 into ioBroker:master Jan 13, 2023
o0shojo0o added a commit to arteck/ioBroker.zigbee2mqtt that referenced this pull request Jan 18, 2023
-   (o0shojo0o) added support for  wildcard actions (eg. *_single) ([#116](#116))
-   (o0shojo0o) added error handling optimizations ([more](ioBroker/ioBroker.repositories#1976 (comment)))
-   (o0shojo0o) added option `auth_token` for websocket connection ([#112](#112))
-   (o0shojo0o) websocket timeout increased
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review question Something needs to be done or answered by the adapter developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants