New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure arbitrary adjoined elements render correctly in matplotlib #1033

Closed
philippjfr opened this Issue Jan 4, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Jan 4, 2017

Currently you can adjoin any element type to another and at least in bokeh they will render correctly in general. However in matplotlib the dimensions of the adjoined plots will often be wrong due to issues with aspects. Additionally many matplotlib plots do not correctly support invert_axes, which leads to the data being plotted incorrectly in those cases. These two issues should be addressed.

@jbednar

This comment has been minimized.

Member

jbednar commented Jan 4, 2017

Will that require changes in matplotlib itself? If so may be worth opening an issue there now so that they are aware of it, even if we don't plan to work on it at our end right away.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jan 4, 2017

No, I think this will just require going through all matplotlib plotting classes and making sure that it behaves correctly when adjoined.

@jbednar

This comment has been minimized.

Member

jbednar commented Jan 4, 2017

How will that help fix invert_axes?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jan 4, 2017

The plotting classes should invert the data appropriately so invert_axes is respected. The AdjointLayoutPlot will then tell the subplot that it should invert the axes if it is adjoined to the right. That's how it works in bokeh and for the few plot types that support it in matplotlib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment