New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using deprecated classes from streamz #2409

Closed
dcferreira opened this Issue Mar 6, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@dcferreira

dcferreira commented Mar 6, 2018

Hi,

It seems holoviews imports streamz.dataframe.StreamingDataFrame and streamz.dataframe.StreamingSeries:

try:
from streamz.dataframe import StreamingDataFrame, StreamingSeries
loaded = True
except ImportError:
loaded = False
if not loaded or not isinstance(data, (StreamingDataFrame, StreamingSeries)):
raise ValueError("Buffer must be initialized with pandas DataFrame, "
"streamz.StreamingDataFrame or streamz.StreamingSeries.")

However, these classes have been deprecated and no longer exist in version streamz 0.3.0.

To reproduce, use the examples given in http://holoviews.org/user_guide/Streaming_Data.html that use such classes. They do not work with streamz==0.3.0.

@philippjfr philippjfr added this to the v1.10 milestone Mar 6, 2018

@philippjfr

This comment has been minimized.

Member

philippjfr commented Mar 6, 2018

Thanks for raising this issue, I've been meaning to file it myself. The code does indeed need to be updated so for now I'd recommend sticking to 0.2.0 or manually connecting the streamz.DataFrame to the Buffer using the .sink method.

@philippjfr philippjfr referenced this issue Mar 8, 2018

Merged

Handle streamz 0.3.0 API changes #2420

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment