Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept xarray DataArray #869

Closed
philippjfr opened this issue Sep 19, 2016 · 4 comments
Closed

Accept xarray DataArray #869

philippjfr opened this issue Sep 19, 2016 · 4 comments
Labels
Milestone

Comments

@philippjfr
Copy link
Member

Currently the xarray interface only supports an xr.Dataset, however a user often has a simple xr.DataArray so the interface should be able to accept a DataArray and automatically wrap it in a Dataset so it can interface with it. This avoids the user from having to do something like:

hv.Dataset(xr.Dataset({'value': xarr}))
@jlstevens
Copy link
Contributor

So after this proposal is implemented, you will simply need hv.Dataset({'value': xarr}) presumably?

If so, this proposal makes perfect sense to me. Though is there anything else that might be of interest to HoloViews that is passed as an argument to the Dataset constructor?

@philippjfr
Copy link
Member Author

No, it will just be:

hv.Dataset(xarr)

where the xr.DataArray should specify the name of the data variable.

@jlstevens
Copy link
Contributor

jlstevens commented Sep 19, 2016

Ok, that also makes sense. If there really is no other information HoloViews needs from the xr.Dataset then I imagine that this proposal will make things much more convenient for xarray users.

@philippjfr philippjfr added this to the v1.7.0 milestone Oct 21, 2016
@philippjfr
Copy link
Member Author

This has been supported since #894. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants