New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Histogram color cycle #1008

Merged
merged 1 commit into from Dec 10, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Dec 10, 2016

As suggested in #918, bokeh Histograms should have the same color cycle as the matplotlib version defined.

Before the PR:

bokeh_plot 20

With the PR:

bokeh_plot 19

@philippjfr philippjfr requested a review from jlstevens Dec 10, 2016

@philippjfr

This comment has been minimized.

Member

philippjfr commented Dec 10, 2016

Would you look at that Travis reporting the exact change in the bokeh data:

{'values_changed': {u"root['roots']['references'][38]['attributes']['fill_color']['value']": {'new_value': u'#036564', 'old_value': u'#30a2da'}}

Tests will have to be updated.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 10, 2016

Looks good and I am happy to merge once the tests are updated and passing.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Dec 10, 2016

Tests regenerated and push builds passed. Ready to merge.

@jlstevens jlstevens merged commit 25ff7d1 into master Dec 10, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 75.996%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the bokeh_histogram_color branch Dec 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment