New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for boolean arrays in bokeh ImagePlot #1014

Merged
merged 1 commit into from Dec 11, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Dec 10, 2016

As described in #727, the bokeh image plots do not currently support boolean arrays. This is because the color mapper does not like boolean low and high values. However since booleans cannot be serialized easily it will be more efficient to send them as int8 arrays, which will be base64 encoded in an upcoming bokeh PR.

@philippjfr philippjfr requested a review from jlstevens Dec 10, 2016

@philippjfr philippjfr added the bokeh label Dec 10, 2016

@philippjfr philippjfr added this to the v1.7.0 milestone Dec 10, 2016

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 11, 2016

Looks good and this is an issue that has bitten me several times before. Good to see it fixed!

Ready to merge?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Dec 11, 2016

Ready.

@jlstevens jlstevens merged commit 46b2733 into master Dec 11, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 75.992%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the bokeh_bool_image branch Dec 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment