New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Layout/Grid titles in bokeh #1017

Merged
merged 5 commits into from Dec 18, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Dec 11, 2016

As I had suggested in #989 it is possible to add a Div as a title to a composite plot. This finally adds consistency in titles between matplotlib and bokeh backends for Layout and Grid plots.

Still needs tests.

Examples

Layout

screen shot 2016-12-11 at 10 24 55 pm

Grid

screen shot 2016-12-11 at 10 27 19 pm

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 12, 2016

That looks good! Shame bokeh doesn't let you do this more directly.

Make sure to test this in Chrome/Firefox/Safari and if you find it is working well, I am happy to merge.

@philippjfr philippjfr removed the WIP label Dec 18, 2016

@philippjfr

This comment has been minimized.

Member

philippjfr commented Dec 18, 2016

Ready to merge when tests pass.

@@ -153,7 +154,43 @@ def sync_sources(self):
class GridPlot(BokehPlot, GenericCompositePlot):
class CompositePlot(BokehPlot):

This comment has been minimized.

@jlstevens

jlstevens Dec 18, 2016

Member

Would be good to have a docstring explaining what this base class is for. Right now, everything CompositePlot does seems to be only needed by LayoutPlot. Any ideas what CompositePlot could be used for that isn't LayoutPlot?

This comment has been minimized.

@philippjfr

philippjfr Dec 18, 2016

Member

GridPlot, just below, but yes I'll add a docstring.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 18, 2016

Looks good, thanks!

@jlstevens jlstevens merged commit d9b0d95 into master Dec 18, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@philippjfr philippjfr deleted the bokeh_composite_titles branch Jan 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment