New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from deprecated bokeh Model.set to Model.update #1036

Merged
merged 1 commit into from Jan 7, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Jan 7, 2017

Simple API change, bokeh's Model.set method was a duplicate of the Model.update method and is now deprecated in >=0.12.4.

@philippjfr philippjfr added the bokeh label Jan 7, 2017

@philippjfr philippjfr requested a review from jlstevens Jan 7, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 7, 2017

Seems like a straightforward search and replace. If it is tested, I am happy to merge.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jan 7, 2017

Yes, there's bokeh unit tests and notebook tests covering these changes and the implementation for the two is effectively the same.

@jlstevens jlstevens merged commit 6be52e0 into master Jan 7, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 76.675%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the bokeh_model_update branch Jan 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment