New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled matplotlib layout fix by default #1037

Merged
merged 2 commits into from Jan 17, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Jan 7, 2017

It's time to enable the matplotlib layout fix by default. There will be changes to the display data, so that will have to be updated, after careful review.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 7, 2017

I agree...though how did you come up with the new vspace value? Trial and error?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jan 7, 2017

I agree...though how did you come up with the new vspace value? Trial and error?

Yeah, just like the previous value, it should behave more predictably now though. I'm not quite sure why the tests are still passing. Will have to review the test data.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 7, 2017

The tests have now passed. Are the tests updated reviewed making this PR ready to merge?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jan 7, 2017

No, for some reason the test data hasn't changed and I can't figure out why.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 10, 2017

It might be worth thinking about how this links to #1041 before merging...

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 10, 2017

And yes, the fact the tests kept passing is weird!

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jan 17, 2017

I guess just merge it, can always revert it if something goes wrong.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 17, 2017

Ok. Hope it works!

@jlstevens jlstevens merged commit 18b87e1 into master Jan 17, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 76.966%
Details
s3-reference-data-cache Tests passing no test data changes required.
Details

@philippjfr philippjfr deleted the layout_fix_enable branch Jan 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment