New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup fixes for HeatMap generalization #1043

Merged
merged 2 commits into from Jan 9, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Jan 9, 2017

Realized I hadn't pushed some final fixes in #849, ready to merge once tests pass.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 9, 2017

Nevermind!

@jlstevens jlstevens closed this Jan 9, 2017

@jlstevens jlstevens reopened this Jan 9, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 9, 2017

Hit the wrong button again! Waiting for the tests...

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jan 9, 2017

Also for reference here's how HeatMap now deals with numeric data:

screen shot 2017-01-09 at 6 39 15 pm

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 9, 2017

@philippjfr Maybe we should have a section of contrib for such examples? Though I suppose it would be hard to get mybinder (or any other approach) to compare between versions/commits...

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 9, 2017

Tests have now passed. Merging.

@jlstevens jlstevens merged commit 4be931a into master Jan 9, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on master at 76.879%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the nd_heatmap branch Jan 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment